Re: intel8x0 dual codec issue

[Takashi Iwai <tiwai@suse.de>]

At Fri, 11 Feb 2005 11:30:49 -0500,
Ron Cococcia wrote:
> 
> [1  <text/plain; ISO-8859-1 (7bit)>]
> Takashi Iwai wrote:
> > At Thu, 10 Feb 2005 14:16:12 -0500,
> > Ron Cococcia wrote:
> > 
> >>I had been looking through that block of code, and had made some of my 
> >>own "tweaks".  What I did was make "reg_ok" an array (size 4, all 
> >>initialized to 0).  I used the codec index (cidx) to index into that 
> >>array.  The idea is that there would be a reg_ok for each codec, instead 
> >>of just 1 for all codecs.  This correctly set the output on all codecs 
> >>after making the change.
> > 
> > 
> > Yeah, that's better than my last hack.  Could you create a patch?
> 
> Attached.  I had a backup copy of the file that I diff'd against.  This 
> is also based off of 1.0.8 files, but from what I could see the 
> ac97_pcm.c file hasn't changed.  You'll also see a few snd_printk's in 
> there that I had for testing/debugging purposes.  You can get rid of 
> them if you want.

Thanks, applied to CVS (yes I removed printks :)

> I'm not sure what the implications of changing the rates on all of the 
> codecs are.  Is it possible that, in a multiple codec configuration, 
> there would be a situation where they would want to be handling 
> different rates?

Well, the current ac97 codec driver doesn't consider the multi stream
case.  And, AFAIK, no controller supports different sample rates for
each codec.  (Different rates can be used for different slots,
though.)


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click