From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: pci_disable_device warning Date: Thu, 18 Nov 2004 14:08:25 +0100 Message-ID: References: <1100716849.6930.31.camel@krustophenia.net> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: multipart/mixed; boundary="Multipart_Thu_Nov_18_14:08:25_2004-1" Return-path: In-Reply-To: <1100716849.6930.31.camel@krustophenia.net> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Lee Revell Cc: alsa-devel List-Id: alsa-devel@alsa-project.org --Multipart_Thu_Nov_18_14:08:25_2004-1 Content-Type: text/plain; charset=US-ASCII At Wed, 17 Nov 2004 13:40:48 -0500, Lee Revell wrote: > > I get this warning when removing ALSA modules. I believe the warning is > going away, so maybe we should address the issue now. Is this something > that could be done by the ALSA middle layer? Possible, but I think better in each driver code. > Nov 16 23:32:09 krustophenia kernel: EMU10K1_Audigy 0000:00:14.0: Device > was removed without properly calling pci_disable_device(). This may need > fixing. > > I tried adding a call to pci_disable_device and the warning persisted, > maybe I did not add it in the right place. Does the patch below fix? Takashi --Multipart_Thu_Nov_18_14:08:25_2004-1 Content-Type: text/plain; charset=US-ASCII Index: alsa-kernel/pci/emu10k1/emu10k1_main.c =================================================================== RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/emu10k1/emu10k1_main.c,v retrieving revision 1.38 diff -u -r1.38 emu10k1_main.c --- alsa-kernel/pci/emu10k1/emu10k1_main.c 30 Jul 2004 12:44:58 -0000 1.38 +++ alsa-kernel/pci/emu10k1/emu10k1_main.c 18 Nov 2004 13:05:28 -0000 @@ -561,6 +561,7 @@ free_irq(emu->irq, (void *)emu); if (emu->port) pci_release_regions(emu->pci); + pci_disable_device(emu->pci); kfree(emu); return 0; } --Multipart_Thu_Nov_18_14:08:25_2004-1-- ------------------------------------------------------- This SF.Net email is sponsored by: InterSystems CACHE FREE OODBMS DOWNLOAD - A multidimensional database that combines robust object and relational technologies, making it a perfect match for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8