All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Georgi Georgiev <chutz@gg3.net>,
	alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: Re: Broken AC3 on EMU10K1 since July 2-nd
Date: Thu, 30 Sep 2004 12:10:34 +0200	[thread overview]
Message-ID: <s5hr7okxe1x.wl@alsa2.suse.de> (raw)
In-Reply-To: <s5hzn3az7bo.wl@alsa2.suse.de>

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

At Tue, 28 Sep 2004 18:28:27 +0200,
I wrote:
> 
> > OK, the problem is almost certainly the introduction of pcm_indirect for
> > the FX8010 PCM.  Takashi-san, do you agree?
> 
> Most likely.  I'll take a look.

The attached oneliner fixes this bug.
Already applied to CVS.


Takashi

[-- Attachment #2: Type: text/plain, Size: 760 bytes --]

Index: alsa-kernel/pci/emu10k1/emupcm.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/emu10k1/emupcm.c,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -r1.35 -r1.36
--- alsa-kernel/pci/emu10k1/emupcm.c	15 Sep 2004 09:43:12 -0000	1.35
+++ alsa-kernel/pci/emu10k1/emupcm.c	30 Sep 2004 10:01:42 -0000	1.36
@@ -1192,7 +1192,7 @@
 	}
 	snd_emu10k1_fx8010_playback_tram_poke1((unsigned short *)emu->fx8010.etram_pages.area + tram_pos,
 					       (unsigned short *)emu->fx8010.etram_pages.area + tram_pos + tram_size / 2,
-					       src, frames, tram_shift++);
+					       src, frames, tram_shift);
 	tram_pos -= frames;
 	pcm->tram_pos = tram_pos;
 	pcm->tram_shift = tram_shift;

  reply	other threads:[~2004-09-30 10:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-27 16:03 Broken AC3 on EMU10K1 since July 2-nd Georgi Georgiev
2004-09-27 16:20 ` Georgi Georgiev
2004-09-27 18:50   ` Lee Revell
     [not found]     ` <20040928051034.GA9175@lion.gg3.net>
2004-09-28 16:24       ` Lee Revell
2004-09-28 16:28         ` Takashi Iwai
2004-09-30 10:10           ` Takashi Iwai [this message]
2004-09-30 14:48             ` Georgi Georgiev
2004-09-27 19:56   ` Takashi Iwai
2004-09-28  5:12     ` Georgi Georgiev
2004-09-28 17:29       ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2004-09-28  6:29 Peter Zubaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hr7okxe1x.wl@alsa2.suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=chutz@gg3.net \
    --cc=rlrevell@joe-job.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.