All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cmipci compile fix
@ 2003-01-06 11:22 Janek Hiis
  2003-01-06 13:37 ` Jaroslav Kysela
  0 siblings, 1 reply; 3+ messages in thread
From: Janek Hiis @ 2003-01-06 11:22 UTC (permalink / raw)
  To: alsa-devel

Hi,

just updated the CVS version and when compiling I get error. Following 
patch (hopefully correct) fixes that:

RCS file: /cvsroot/alsa/alsa-kernel/pci/cmipci.c,v retrieving revision 1.37
diff -u -3 -p -u -r1.37 cmipci.c
--- cmipci.c    3 Jan 2003 09:44:20 -0000       1.37
+++ cmipci.c    6 Jan 2003 11:20:07 -0000
@@ -2949,13 +2949,12 @@ static int __devinit snd_cmipci_create(s

        /* Assume TX and compatible chip set (Autodetection required for VX chip sets) */
        switch (pci->device) {
-               struct list_head *pos;
                int txvx;
        case PCI_DEVICE_ID_CMEDIA_CM8738:
        case PCI_DEVICE_ID_CMEDIA_CM8738B:
                txvx = 1;
-               pci_for_each_dev(pos) {
-                       struct pci_dev * cur = list_entry(pos, struct pci_dev, global_list);
+               pci_for_each_dev(pci) {
+                       struct pci_dev * cur = list_entry(pci, struct pci_dev, global_list);
                        if (cur->vendor != 0x8086) /* PCI_VENDOR_ID_INTEL */
                                continue;
                        if (cur->device != 0x7030) /* PCI_DEVICE_ID_INTEL_82437VX */


Janek Hiis



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cmipci compile fix
  2003-01-06 11:22 [PATCH] cmipci compile fix Janek Hiis
@ 2003-01-06 13:37 ` Jaroslav Kysela
  2003-01-07 15:54   ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Jaroslav Kysela @ 2003-01-06 13:37 UTC (permalink / raw)
  To: Janek Hiis; +Cc: alsa-devel@lists.sourceforge.net

On Mon, 6 Jan 2003, Janek Hiis wrote:

> Hi,
> 
> just updated the CVS version and when compiling I get error. Following 
> patch (hopefully correct) fixes that:

I put slightly different fix to CVS, but thanks for notice.

						Jaroslav

-----
Jaroslav Kysela <perex@suse.cz>
Linux Kernel Sound Maintainer
ALSA Project, SuSE Labs



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cmipci compile fix
  2003-01-06 13:37 ` Jaroslav Kysela
@ 2003-01-07 15:54   ` Takashi Iwai
  0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2003-01-07 15:54 UTC (permalink / raw)
  To: Jaroslav Kysela; +Cc: Janek Hiis, alsa-devel@lists.sourceforge.net

At Mon, 6 Jan 2003 14:37:08 +0100 (CET),
Jaroslav wrote:
> 
> On Mon, 6 Jan 2003, Janek Hiis wrote:
> 
> > Hi,
> > 
> > just updated the CVS version and when compiling I get error. Following 
> > patch (hopefully correct) fixes that:
> 
> I put slightly different fix to CVS, but thanks for notice.

i think pci_find_device() do this job nicely.
(already changed on cvs, btw :)


Takashi


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-01-07 15:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-01-06 11:22 [PATCH] cmipci compile fix Janek Hiis
2003-01-06 13:37 ` Jaroslav Kysela
2003-01-07 15:54   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.