Re: [RFC] merging splited driver back

[Takashi Iwai <tiwai@suse.de>]

Hi,

At Mon, 19 Aug 2002 22:29:12 +0200,
Thierry Vignaud wrote:
> 
> snd-ens1370 and 1371're just the same driver which compilation is
> altered by preprocessors directives.
> 
> snd-via8232 came from via686 and some common code can still be seen.
> 
> it would be nice if the alsa team can make a unified snd-ens137[01]
> driver and a snd-via-common sub module used by snd-via{686,8232}.

both jobs would be relatively easy.
in fact, integration of ens137x was already done experimentally on my
tree, and the change for via driver should be also small.

but the decision is different.

pro:
  - merging via drivers will make the maintenance and bug-hunt easier.
    merging ens137x drivers makes no difference, because it's already
    in a source.

con:
  - merging two drivers to a unified driver will increase the size.
  - we may put the common stuff into lowlevel module.  but the
    lowlevel module cannot be marked as __devinit, although this
    doesn't matter for modules anyway.


basically i vote for this action, but i'd like to hear the opinion
from other people in this regard.


Takashi


-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old
cell phone?  Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390