From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5912FC433F5 for ; Mon, 7 Feb 2022 16:11:17 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 46E121836; Mon, 7 Feb 2022 17:10:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 46E121836 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1644250275; bh=B/nxmY7EyZuB9VePNCO5j2tb6NlvtsnO37UDPgc3oWs=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bhvCXDVn/X3HX4ZuPT810WUqhxeyCiLs9zX80yH7XKkotCkREfT337FJkF0T+jkb6 AWr8Y6YGtEpIO/e6UROMgumE5RfA/wXE162xpqkdxYw/1UT9iugZZDQz93238cLMv+ E5z7kyZvSMi2ImWVK3sLIWomzJu2lAkonHhqQNzQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DE199F80240; Mon, 7 Feb 2022 17:10:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D2C6DF80246; Mon, 7 Feb 2022 17:10:22 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 43F64F800F5 for ; Mon, 7 Feb 2022 17:10:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 43F64F800F5 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="i8IRCgVh"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="jlYuTVoy" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 92DA91F37E; Mon, 7 Feb 2022 16:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1644250219; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dVOa8XGIp5DLIL4tTlJLbaMRsQatnR/OajkKQCMIv8U=; b=i8IRCgVhiupXohd6nYjhcDJUvvrcp2XSHParhS+S7TfdC3jpgm/y+24HuywhNi1AmEzKZt Z0iVoFCBfo9QqquI90ElG+zB6aLQnxBRIHzxOfnetNHiIB+7gKODbTWG6zlDANP87yVxJr qb+v8QItTT0Kotabn2cI8lRrlFK5Hf8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1644250219; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dVOa8XGIp5DLIL4tTlJLbaMRsQatnR/OajkKQCMIv8U=; b=jlYuTVoyoBavi0rBZBvHmXcBmnGSrWbV04t0gJrGclpL8WyBzV9nqLEczhKrIRYzJVyBnA Dhj5Estxdal8w3Ag== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 76A16A3B83; Mon, 7 Feb 2022 16:10:19 +0000 (UTC) Date: Mon, 07 Feb 2022 17:10:19 +0100 Message-ID: From: Takashi Iwai To: Colin Ian King Subject: Re: [PATCH] ALSA: usb-audio: remove redundant assignment to variable c In-Reply-To: <20220207140617.341172-1-colin.i.king@gmail.com> References: <20220207140617.341172-1-colin.i.king@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 07 Feb 2022 15:06:17 +0100, Colin Ian King wrote: > > The variable c is being initialized in an outer for-loop and also > re-initialized inside an inner for-loop. The first initialization > is redundant and can be removed. > > Signed-off-by: Colin Ian King The code change looks OK, but when I apply your patch now, git-am converts the Author address to your new @intel.com, and this mismatches with the address in Signed-off-by. Should I keep the original gmail address, or would you fix up your Signed-off-by (and From) for avoiding those inconsistency? thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F4BCC4707E for ; Mon, 7 Feb 2022 16:22:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241868AbiBGQWL (ORCPT ); Mon, 7 Feb 2022 11:22:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237064AbiBGQKY (ORCPT ); Mon, 7 Feb 2022 11:10:24 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5847C0401D8; Mon, 7 Feb 2022 08:10:20 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 92DA91F37E; Mon, 7 Feb 2022 16:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1644250219; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dVOa8XGIp5DLIL4tTlJLbaMRsQatnR/OajkKQCMIv8U=; b=i8IRCgVhiupXohd6nYjhcDJUvvrcp2XSHParhS+S7TfdC3jpgm/y+24HuywhNi1AmEzKZt Z0iVoFCBfo9QqquI90ElG+zB6aLQnxBRIHzxOfnetNHiIB+7gKODbTWG6zlDANP87yVxJr qb+v8QItTT0Kotabn2cI8lRrlFK5Hf8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1644250219; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dVOa8XGIp5DLIL4tTlJLbaMRsQatnR/OajkKQCMIv8U=; b=jlYuTVoyoBavi0rBZBvHmXcBmnGSrWbV04t0gJrGclpL8WyBzV9nqLEczhKrIRYzJVyBnA Dhj5Estxdal8w3Ag== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 76A16A3B83; Mon, 7 Feb 2022 16:10:19 +0000 (UTC) Date: Mon, 07 Feb 2022 17:10:19 +0100 Message-ID: From: Takashi Iwai To: Colin Ian King Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: remove redundant assignment to variable c In-Reply-To: <20220207140617.341172-1-colin.i.king@gmail.com> References: <20220207140617.341172-1-colin.i.king@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Mon, 07 Feb 2022 15:06:17 +0100, Colin Ian King wrote: > > The variable c is being initialized in an outer for-loop and also > re-initialized inside an inner for-loop. The first initialization > is redundant and can be removed. > > Signed-off-by: Colin Ian King The code change looks OK, but when I apply your patch now, git-am converts the Author address to your new @intel.com, and this mismatches with the address in Signed-off-by. Should I keep the original gmail address, or would you fix up your Signed-off-by (and From) for avoiding those inconsistency? thanks, Takashi