All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Pshou <pshou@realtek.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Kailang <kailang@realtek.com>, "tiwai@suse.com" <tiwai@suse.com>
Subject: Re: 回覆: CLEVO uses the model name and SSID list of Realtek audio CODEC ALC1220
Date: Mon, 18 May 2020 16:15:17 +0200	[thread overview]
Message-ID: <s5hsgfxib2i.wl-tiwai@suse.de> (raw)
In-Reply-To: <dd45ef275b494538a4d4748480698c78@realtek.com>

On Mon, 18 May 2020 11:13:48 +0200,
Pshou wrote:
> 
> Hi Takash:
> 
> I have added the "Signed-off-by" line.
> Can you see if you can?
> 
> Signed-off-by: Pshou <pshou@realtek.com>

We need a real full name here to Signed-off-by line.  It's a legal
requirement.  Could you fill it and resend?


thanks,

Takashi

> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> 
> Best regards
> Pshou
> 
> -----原始郵件-----
> 寄件者: Takashi Iwai <tiwai@suse.de> 
> 寄件日期: 2020年5月15日 17:45
> 收件者: Pshou <pshou@realtek.com>
> 副本: tiwai@suse.com; Kailang <kailang@realtek.com>
> 主旨: Re: CLEVO uses the model name and SSID list of Realtek audio CODEC ALC1220
> 
> On Fri, 15 May 2020 11:24:45 +0200,
> Pshou wrote:
> > 
> > Hi Takashi:
> > 
> > Can you help me add some source code to patch_realtek.c?
> > 
> > Add some CLEVO SSID in the alc1220.
> > 
> >         SND_PCI_QUIRK(0x1558, 0x67d1, "Clevo PB71[ER][CDF]", 
> > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > 
> > +      SND_PCI_QUIRK(0x1558, 0x50d3, "Clevo PC50[ER][CDF]",
> > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > 
> > +      SND_PCI_QUIRK(0x1558, 0x70d1, "Clevo PC70[ER][CDF]",
> > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > 
> > +      SND_PCI_QUIRK(0x1558, 0x7714, "Clevo X170",
> > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > 
> >       SND_PCI_QUIRK_VENDOR(0x1558, "Clevo laptop", ALC882_FIXUP_EAPD),
> 
> Sure, could you give your Signed-off-by line, so that I can rearrange, submit to alsa-devel and merge to upstream?
> 
> 
> thanks,
> 
> Takashi
> 
> ------Please consider the environment before printing this e-mail.
> [2 0001-Add-several-Clevo-SSID-in-the-ALC1220.patch <application/octet-stream (base64)>]
> 

       reply	other threads:[~2020-05-18 14:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <63d2069dd6394e0195739bd9dd3de5d0@realtek.com>
     [not found] ` <s5hsgg1mszs.wl-tiwai@suse.de>
     [not found]   ` <dd45ef275b494538a4d4748480698c78@realtek.com>
2020-05-18 14:15     ` Takashi Iwai [this message]
2020-05-19  6:39       ` 回覆: 回覆: CLEVO uses the model name and SSID list of Realtek audio CODEC ALC1220 Pshou
2020-05-19  6:50         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hsgfxib2i.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=kailang@realtek.com \
    --cc=pshou@realtek.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.