From: Takashi Iwai <tiwai@suse.de>
To: Mengdong Lin <mengdong.lin@linux.intel.com>
Cc: alsa-devel@alsa-project.org, mengdong.lin@intel.com,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
liam.r.girdwood@linux.intel.com, broonie@kernel.org,
pierre-louis.bossart@intel.com
Subject: Re: [PATCH] ASoC: snd_soc_set_dmi_name will use DMI_SYS_VENDOR if available
Date: Tue, 02 May 2017 12:41:00 +0200 [thread overview]
Message-ID: <s5hshkntubn.wl-tiwai@suse.de> (raw)
In-Reply-To: <5908627D.3040305@linux.intel.com>
On Tue, 02 May 2017 12:42:05 +0200,
Mengdong Lin wrote:
>
> Daniel and I have tested this patch on our platforms.
>
> On 04/29/2017 12:40 AM, Pierre-Louis Bossart wrote:
> > On 4/28/17 11:19 AM, mengdong.lin@linux.intel.com wrote:
> >> From: Mengdong Lin <mengdong.lin@linux.intel.com>
> >>
> >> This fix is based on Daniel Drake's suggestion: most x86 machines have a
> >> meaningfull DMI_SYS_VENDOR rather than DMI_BOARD_VENDOR.
> >>
> >> So snd_soc_set_dmi_name will try to get vendor name from DMI_SYS_VENDOR
> >> at first, and if that's null, then use DMI_BOARD_VENDOR.
> >>
> >> Signed-off-by: Mengdong Lin <mengdong.lin@linux.intel.com>
> >>
> >> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> >> index 525f2f3..45f0a34 100644
> >> --- a/sound/soc/soc-core.c
> >> +++ b/sound/soc/soc-core.c
> >> @@ -1974,7 +1974,9 @@ int snd_soc_set_dmi_name(struct snd_soc_card
> >> *card, const char *flavour)
> >> return 0; /* long name already set by driver or from DMI */
> >>
> >> /* make up dmi long name as: vendor.product.version.board */
> >> - vendor = dmi_get_system_info(DMI_BOARD_VENDOR);
> >> + vendor = dmi_get_system_info(DMI_SYS_VENDOR);
> >> + if (!vendor)
> >> + vendor = dmi_get_system_info(DMI_BOARD_VENDOR);
> >
> > We should also test all of vendor.product.version.board fields for "(To
> > be filled by OEM)" and "Default String" and limit each field to 20
> > characters if you want to stick with 80 total (or a smarter rule that
> > does not truncate a field if there was room saved by the others)
>
> Now the risk on string size seems okay. The maximum size of the
> vendor.product.version.board is about 60 characters found in my test
> for some Lenovo, DELL, ASUS, Minnowboard and Intel machines.
>
> Usually each field has 10 ~ 20 characters. Since it's difficult to
> judge which part in the string is more important, we just copy,
> concatenate and limit the total size of the concatenated string.
> But to save size, we've stripped SPACE characters from each field to
> reduce the string size. And if a DMI field is null, it will be skipped
> without any "Default string".
Well, the two strings, "(To be filled by OEM)" and "Default String",
are known to be bogus, and actually found on many devices with
premature BIOS, so we can safely skip them.
Takashi
prev parent reply other threads:[~2017-05-02 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 16:19 [PATCH] ASoC: snd_soc_set_dmi_name will use DMI_SYS_VENDOR if available mengdong.lin
2017-04-28 16:40 ` Pierre-Louis Bossart
2017-05-02 10:42 ` Mengdong Lin
2017-05-02 10:41 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hshkntubn.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mengdong.lin@intel.com \
--cc=mengdong.lin@linux.intel.com \
--cc=pierre-louis.bossart@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.