From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [RFC PATCH 4/4] ALSA - hda: add DP MST support Date: Mon, 07 Mar 2016 16:19:24 +0100 Message-ID: References: <1457362666-53937-1-git-send-email-libin.yang@linux.intel.com> <1457362666-53937-5-git-send-email-libin.yang@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id AA51626145A for ; Mon, 7 Mar 2016 16:19:26 +0100 (CET) In-Reply-To: <1457362666-53937-5-git-send-email-libin.yang@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: libin.yang@linux.intel.com Cc: libin.yang@intel.com, mengdong.lin@intel.com, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Mon, 07 Mar 2016 15:57:46 +0100, libin.yang@linux.intel.com wrote: > > From: Libin Yang > > This patch adds the DP MST support in hdmi audio driver. > --- > sound/pci/hda/hda_codec.c | 3 + > sound/pci/hda/patch_hdmi.c | 167 +++++++++++++++++++++++++++++++-------------- > 2 files changed, 120 insertions(+), 50 deletions(-) > > diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c > index 1a42c51..7244f87 100644 > --- a/sound/pci/hda/hda_codec.c > +++ b/sound/pci/hda/hda_codec.c > @@ -589,6 +589,9 @@ static int read_pin_defaults(struct hda_codec *codec) > pin->nid = nid; > pin->cfg = snd_hda_codec_read(codec, nid, 0, > AC_VERB_GET_CONFIG_DEFAULT, 0); > + /* all device entries are the same widget control so far > + * fixme: if any codec is different, need fix here > + */ > pin->ctrl = snd_hda_codec_read(codec, nid, 0, > AC_VERB_GET_PIN_WIDGET_CONTROL, > 0); > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c > index 11be04a..26f5efd 100644 > --- a/sound/pci/hda/patch_hdmi.c > +++ b/sound/pci/hda/patch_hdmi.c > @@ -144,7 +144,9 @@ struct hdmi_spec { > struct snd_array cvts; /* struct hdmi_spec_per_cvt */ > hda_nid_t cvt_nids[4]; /* only for haswell fix */ > > - int num_pins; > + int num_pins; /* number of pins (including device entries) */ > + int num_nids; /* number of pin nids*/ > + int dev_num; These new definitions are unclear to me. Please give a bit more detailed comments there. e.g. what actually means "including device entries"? You can give some example there. I suppose num_nids is the actual number of pins, right? Also what is dev_num? It's not an index, right? thanks, Takashi