From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com,
patches@opensource.wolfsonmicro.com,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
lgirdwood@gmail.com,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Subject: Re: [RFC PATCH] ALSA: compress: Add SND_AUDIOCODEC_BESPOKE
Date: Sat, 24 Oct 2015 09:36:48 +0200 [thread overview]
Message-ID: <s5hsi50afan.wl-tiwai@suse.de> (raw)
In-Reply-To: <20151020193711.GF32054@sirena.org.uk>
On Tue, 20 Oct 2015 21:37:11 +0200,
Mark Brown wrote:
>
> On Tue, Oct 20, 2015 at 12:47:58PM -0500, Pierre-Louis Bossart wrote:
>
> > Since this is clearly an escape mechanism for a non-standard codec, maybe we
> > should use an ID that's not in sequence, eg 0x00001000.
>
> 0xDEADBEEF. Also the bikeshed should be purple :)
Oh, let's make it more brilliant like gold over shocking pink :)
Usually the number like 0x1000 makes sense only when the lower bits
are used for relevant purpose, e.g. as a sub-type definition for
BESPOKE. So, type_is_bespoke() won't be "type == 0x1000" but
"type & 0x1000".
Takashi
prev parent reply other threads:[~2015-10-24 7:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 13:39 [RFC PATCH] ALSA: compress: Add SND_AUDIOCODEC_BESPOKE Charles Keepax
2015-10-20 17:47 ` Pierre-Louis Bossart
2015-10-20 19:37 ` Mark Brown
2015-10-21 15:32 ` [RFC PATCH] ALSA: compress: Add SND_AUDIOCODEC_BESPOKE' Vinod Koul
2015-10-21 15:36 ` Charles Keepax
2015-10-21 18:46 ` Pierre-Louis Bossart
2015-11-05 5:57 ` Vinod Koul
2015-11-05 9:50 ` Charles Keepax
2015-10-24 7:36 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsi50afan.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.