From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 0/5] PCM mmap (temporary) fixes for non-coherent architectures Date: Thu, 14 Jan 2010 08:54:08 +0100 Message-ID: References: <1259248388-20095-1-git-send-email-tiwai@suse.de> <20100101193130.GA21510@rhlx01.hs-esslingen.de> <20100114074638.GA12266@rhlx01.hs-esslingen.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id BC81B24368 for ; Thu, 14 Jan 2010 08:54:11 +0100 (CET) In-Reply-To: <20100114074638.GA12266@rhlx01.hs-esslingen.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Andreas Mohr Cc: linux-mips@linux-mips.org, alsa-devel@alsa-project.org, Thomas Bogendoerfer , Becky Bruce , Wu Zhangjin , Benjamin Herrenschmidt , Ralf Baechle , Kumar Gala List-Id: alsa-devel@alsa-project.org At Thu, 14 Jan 2010 08:46:38 +0100, Andreas Mohr wrote: > > On Wed, Jan 13, 2010 at 10:07:32AM +0100, Takashi Iwai wrote: > > > As I mentioned in the previous followup, if your device is a > > > USB-audio, the patch doesn't help because it's for devices with > > > buffers using dma_alloc_coherent(). For USB-audio, it uses vmalloc > > > for an intermediate buffer. Maybe this should be changed to dma_*() > > > stuff for such architectures. > > > > A quick patch below (totally untested!) might do that. > > It's passing the device struct blindly, so not sure whether this would > > actually work for all dma_alloc_coherent(). > > Thanks a lot, tested, but AFAICS there isn't much of a change unfortunately > (log below). Of course, not for the crash. The patch was for improving the sound quality (if any). Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 14 Jan 2010 08:54:16 +0100 (CET) Received: from cantor.suse.de ([195.135.220.2]:56052 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1491056Ab0ANHyL (ORCPT ); Thu, 14 Jan 2010 08:54:11 +0100 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 3E8E88D893; Thu, 14 Jan 2010 08:54:09 +0100 (CET) Date: Thu, 14 Jan 2010 08:54:08 +0100 Message-ID: From: Takashi Iwai To: Andreas Mohr Cc: alsa-devel@alsa-project.org, Ralf Baechle , Wu Zhangjin , Thomas Bogendoerfer , linux-mips@linux-mips.org, Benjamin Herrenschmidt , Kumar Gala , Becky Bruce Subject: Re: [PATCH 0/5] PCM mmap (temporary) fixes for non-coherent architectures In-Reply-To: <20100114074638.GA12266@rhlx01.hs-esslingen.de> References: <1259248388-20095-1-git-send-email-tiwai@suse.de> <20100101193130.GA21510@rhlx01.hs-esslingen.de> <20100114074638.GA12266@rhlx01.hs-esslingen.de> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-archive-position: 25588 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: tiwai@suse.de Precedence: bulk X-list: linux-mips Return-Path: X-Keywords: X-UID: 9225 At Thu, 14 Jan 2010 08:46:38 +0100, Andreas Mohr wrote: > > On Wed, Jan 13, 2010 at 10:07:32AM +0100, Takashi Iwai wrote: > > > As I mentioned in the previous followup, if your device is a > > > USB-audio, the patch doesn't help because it's for devices with > > > buffers using dma_alloc_coherent(). For USB-audio, it uses vmalloc > > > for an intermediate buffer. Maybe this should be changed to dma_*() > > > stuff for such architectures. > > > > A quick patch below (totally untested!) might do that. > > It's passing the device struct blindly, so not sure whether this would > > actually work for all dma_alloc_coherent(). > > Thanks a lot, tested, but AFAICS there isn't much of a change unfortunately > (log below). Of course, not for the crash. The patch was for improving the sound quality (if any). Takashi