From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Sleep fix for iBook 800 sound Date: Wed, 07 Apr 2004 11:35:55 +0200 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: <1081319128.1780.59.camel@localhost> <1081319710.1401.46.camel@gaston> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from Cantor.suse.de (ns.suse.de [195.135.220.2]) by alsa.alsa-project.org (8.9.3/8.9.3/SuSE Linux 8.9.3-0.1) with ESMTP id LAA26625 for ; Wed, 7 Apr 2004 11:39:07 +0200 In-Reply-To: <1081319710.1401.46.camel@gaston> Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Benjamin Herrenschmidt Cc: Ian McKellar , perex@suse.cz, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org Hi, At Wed, 07 Apr 2004 16:35:11 +1000, Benjamin Herrenschmidt wrote: > > On Wed, 2004-04-07 at 16:25, Ian McKellar wrote: > > So, > > > > I have an iBook 800Mhz and since I've moved to alsa and linux 2.6 I've > > had issues with sound oopsing in sleep, kind of like this: > > Is sound working at all ? I suspect you didn't have the i2c-keywest > module insmod'ed. There is indeed a problem in all our i2c based > sound drivers where we don't always check that the i2c client was > instanciated before doing some things... > > Takashi, how is this patch ? yes, the patch is fine, but i guess it won't fix Ian's mixer problem after resume. the real problem is that i2c.client is reset to NULL in sleep_notify callback. i just took a quick look at dmasound code again, but the code path looks almost same, i.e. sleep_notify_callback(PBOOK_WAKE) -> leave_sleep callback -> resume mixer values maybe dmasound resumes the mixer setting in somewhere else, too? Takashi ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click