Re: cs4248 / thinkpad 755 / 755c , patch suggestions [PATCH]]

[Takashi Iwai <tiwai@suse.de>]

At Mon, 7 Jul 2003 15:53:57 -0500,
Ryan Underwood wrote:
> 
> Hi Takashi,
> 
> On Thu, Jul 03, 2003 at 02:29:01PM +0200, Takashi Iwai wrote:
> > At Wed, 2 Jul 2003 15:29:55 -0500,
> > Ryan Underwood wrote:
> > > 
> > > 1) What is ALSA's policy on module options?  For example, would it be
> > > okay to add an option like "thinkpad" to the ad1848 module, so that
> > > inserting it with "thinkpad=1" would cause the necessary ports to be
> > > prodded?
> > 
> > this looks like a feasible solution.
> > 
> > > 2) Since the chip's power mode can be controlled through a write to that
> > > port (bit 2 on, cs4248 power on; bit 2 off, cs4248 power off), would it
> > > be a good idea to add the _suspend, _resume, and _set_power_state
> > > functions within a #ifdef CONFIG_PM block, like in other drivers?
> > 
> > yep.  we haven't done that just becase of lack of hardware.
> > if you can write and test it, it would be greatly appreciated.
> 
> I have attached a patch against the ALSA 0.94.  ad1848.c, ad1848_lib.c,
> and ad1848.h have changed.

thanks!

i applied the patch to cvs with a small modification.
instead of adding a new argument, i created a new hardware type
AD1848_HW_THINKPAD, so that the function call is kept compatible.


> One issue is to note, I don't know if this is a problem with the ad1848
> driver in general or what; if I cat a 11025hz mono 8-bit file to
> /dev/dsp, the sound comes out verrrrry slllloooowwwllly.   But using
> aplay, it works fine.

could you check the parameters in /proc/asound/card0/pcm0p/sub0/*
during playback via oss?

> I am not sure the best way to test the power managmeent code -- it
> doesn't crash the machine at least. ;)

it looks ok - but i guess we need to restore the registers (mixer
status, etc) too.


Takashi


-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01