From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09EC9C433ED for ; Wed, 12 May 2021 07:09:30 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BDA161260 for ; Wed, 12 May 2021 07:09:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BDA161260 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EED7A185A; Wed, 12 May 2021 09:08:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EED7A185A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1620803364; bh=YAqEkIu2Ts6oANXrZ+EKXBuCjW6U7nGFHngwyndivbw=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NOK1BL+s1jSarkCs31oiuJZBhmFHOVAXuL/x4QbUvM8v4nnEDAB2NburWXTNmIB9H 1i3ORNGEJ89C9bcvaYcYqyxnONo7B6mQXg3h2L17YmSPr6iq0HTxe9lVblSIWwDmXL JV3ztFpa15Tt31fovdI1WcAWqY/WgSjqnIaQ9ph8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7B7CCF800E9; Wed, 12 May 2021 09:08:33 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 36BBDF8012E; Wed, 12 May 2021 09:08:32 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 15ACDF8012E for ; Wed, 12 May 2021 09:08:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 15ACDF8012E X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D2BD8AEF8; Wed, 12 May 2021 07:08:18 +0000 (UTC) Date: Wed, 12 May 2021 09:08:18 +0200 Message-ID: From: Takashi Iwai To: Chanho Park Subject: Re: [PATCH] ALSA: pcm: Need to check whether runtime is valid or not In-Reply-To: <20210512044323.106673-1-chanho61.park@samsung.com> References: <20210512044323.106673-1-chanho61.park@samsung.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen , Pierre-Louis Bossart , Takashi Iwai , eunwoo kim , Vinod Koul X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 12 May 2021 06:43:23 +0200, Chanho Park wrote: > > From: eunwoo kim > > Since snd_pcm_ioctl_sw_params_compat has no runtime variable check, > if application call the ioctl after close, it can make kernel crash. > So, snd_pcm_ioctl_sw_params_compat needs to check the runtime variable > at the beginning of the function. In principle, you cannot call ioctl for an already closed file. Or do you mean other code path? Takashi