From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F950C4361B for ; Tue, 8 Dec 2020 17:58:40 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3134823B3E for ; Tue, 8 Dec 2020 17:58:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3134823B3E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8AFFF16D2; Tue, 8 Dec 2020 18:57:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8AFFF16D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1607450317; bh=gobiweNBWclYHmRqp5A/Fe2Ofv8ziEKEPztfdHb7lZY=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=N+SG46JEjy7uK1ATTYboBPPyLP/5NWh3k8uZ5odk3dh1SdhU/3J9w3sqtP4xeOxLh x83JNfA/l06esss/rQU9mgMpOseNN7j1wqlYDkyzDnB20Hm4wZIEOuO1SVLLOKIX4p jE1t5IaUYpMeD/B2FiFT5Z2yF6jrm+sN5fV8p7QU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0A96BF800E1; Tue, 8 Dec 2020 18:57:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 41C7BF8019D; Tue, 8 Dec 2020 18:57:45 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 22FEBF80130 for ; Tue, 8 Dec 2020 18:57:40 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 22FEBF80130 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9EC2BAD0B; Tue, 8 Dec 2020 17:57:39 +0000 (UTC) Date: Tue, 08 Dec 2020 18:57:39 +0100 Message-ID: From: Takashi Iwai To: "Mukunda,Vijendar" Subject: Re: [PATCH] ASoC: AMD Renoir - add DMI table to avoid the ACP mic probe (broken BIOS) In-Reply-To: <2e4587f8-f602-cf23-4845-fd27a32b1cfc@amd.com> References: <20201208153654.2733354-1-perex@perex.cz> <20201208174002.GH6686@sirena.org.uk> <2e4587f8-f602-cf23-4845-fd27a32b1cfc@amd.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: ALSA development , Mark Brown , stable@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 08 Dec 2020 19:06:21 +0100, Mukunda,Vijendar wrote: > > > > On 08/12/20 11:10 pm, Mark Brown wrote: > > On Tue, Dec 08, 2020 at 05:24:32PM +0100, Takashi Iwai wrote: > > > >> BTW, both Raven and Reonir drivers point to the very same PCI ID, > >> and both drivers will be probed for this machine (and both to be > >> skipped). > > > > Ugh, that's not good. It's not even super obvious from the code that > > this is happening. Seems like it should be one core driver which > > instantiates the components for Raven and Reonir as appropriate, the PCI > > driver is pretty thin at present anyway. > > > > Raven and Renoir has same PCI ID but both platforms have different > revision ID. Raven platform revision id is 0x00 where as for Renoir it > is 0x01. But your drivers don't check the revision ID, as far as I see? The linux PCI driver doesn't distinguish the revision id at the matching time, unfortunately. Takashi