From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB4F0C433DF for ; Wed, 8 Jul 2020 07:14:11 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DB1A20760 for ; Wed, 8 Jul 2020 07:14:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="IPKL0SOg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DB1A20760 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CFFD215E5; Wed, 8 Jul 2020 09:13:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CFFD215E5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594192449; bh=Dae+cIugq4fbH46LZEXD56zyt+w0rIXjG4/ItQi+eww=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IPKL0SOgsabsmGX5zxw2vK0M8vPS1mPtxHtTUtfGLIQ5koYWiNBu870cmQYZ4BwgJ bPa/W3krgciV5TX6fQrBFyEzi+6IHXSsRP6ZjLs5goIfYFMt6x685/PnPDpbl5eBOH d0qKZgWOELQullrq2LtTsJxpFo4lMK0NmEGwkwPA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7B962F8015A; Wed, 8 Jul 2020 09:13:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 74BBAF8015D; Wed, 8 Jul 2020 09:13:18 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0CA17F80150 for ; Wed, 8 Jul 2020 09:13:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0CA17F80150 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 84907ACA0; Wed, 8 Jul 2020 07:13:11 +0000 (UTC) Date: Wed, 08 Jul 2020 09:13:10 +0200 Message-ID: From: Takashi Iwai To: "Gustavo A. R. Silva" Subject: Re: [PATCH] ALSA: Use fallthrough pseudo-keyword In-Reply-To: <20200707172847.GA27659@embeddedor> References: <20200707172847.GA27659@embeddedor> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Nicolas Ferre , linux-kernel@vger.kernel.org, Takashi Iwai , Ludovic Desroches , linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 07 Jul 2020 19:28:47 +0200, Gustavo A. R. Silva wrote: > --- a/sound/isa/msnd/msnd_pinnacle_mixer.c > +++ b/sound/isa/msnd/msnd_pinnacle_mixer.c > @@ -219,8 +219,7 @@ static int snd_msndmix_set(struct snd_msnd *dev, int d, int left, int right) > case MSND_MIXER_VOLUME: /* master volume */ > writew(wLeft, dev->SMA + SMA_wCurrMastVolLeft); > writew(wRight, dev->SMA + SMA_wCurrMastVolRight); > - /* fall through */ > - > + fallthrough; > case MSND_MIXER_AUX: /* aux pot control */ > /* scaled by master volume */ > /* fall through */ Any reason to leave this? thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B718EC433DF for ; Wed, 8 Jul 2020 07:15:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 865C5206DF for ; Wed, 8 Jul 2020 07:15:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XreEefSi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 865C5206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7Bk+xQwWcy/6hvRn05rMzGxWV+v6fdLnFPa/fNVZtxA=; b=XreEefSi0uI0FwTOkTDhWwxPF HA7yNPPcUllwNfuPOsqCtg3jvYKNe7FnI26XujiKyyRXCXInHGFaOJXzXXjCCz79KIzzyj1N0t25D SGlrpWYpmzw909lPkFwepBqPswINH3F70mL8ew13QGhyJ3myQDYJ2ikEwnonADsx+UJsBIOgqlmNR SmS0VUzlqfOoBgaktpim08ZqE04BGLSuB2q8Ew8UAi3FFjMVeds/PMTtzwe5ncyI8EWayC0Ey4gkz 9leg4Nd/QKfezGMkAmAicCV8X0S41GkeHxRvm3Fcc/KMQ785pJoPe0mRx3fwIgLeB9sXzMQVIVLnE H43rWdweg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jt4Ga-0000qJ-92; Wed, 08 Jul 2020 07:13:16 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jt4GX-0000pW-UL for linux-arm-kernel@lists.infradead.org; Wed, 08 Jul 2020 07:13:14 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 84907ACA0; Wed, 8 Jul 2020 07:13:11 +0000 (UTC) Date: Wed, 08 Jul 2020 09:13:10 +0200 Message-ID: From: Takashi Iwai To: "Gustavo A. R. Silva" Subject: Re: [PATCH] ALSA: Use fallthrough pseudo-keyword In-Reply-To: <20200707172847.GA27659@embeddedor> References: <20200707172847.GA27659@embeddedor> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200708_031314_106194_0DEAD428 X-CRM114-Status: GOOD ( 13.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Ludovic Desroches , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 07 Jul 2020 19:28:47 +0200, Gustavo A. R. Silva wrote: > --- a/sound/isa/msnd/msnd_pinnacle_mixer.c > +++ b/sound/isa/msnd/msnd_pinnacle_mixer.c > @@ -219,8 +219,7 @@ static int snd_msndmix_set(struct snd_msnd *dev, int d, int left, int right) > case MSND_MIXER_VOLUME: /* master volume */ > writew(wLeft, dev->SMA + SMA_wCurrMastVolLeft); > writew(wRight, dev->SMA + SMA_wCurrMastVolRight); > - /* fall through */ > - > + fallthrough; > case MSND_MIXER_AUX: /* aux pot control */ > /* scaled by master volume */ > /* fall through */ Any reason to leave this? thanks, Takashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FFA8C433DF for ; Wed, 8 Jul 2020 07:13:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85A97206DF for ; Wed, 8 Jul 2020 07:13:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730031AbgGHHNM (ORCPT ); Wed, 8 Jul 2020 03:13:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:50618 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729836AbgGHHNM (ORCPT ); Wed, 8 Jul 2020 03:13:12 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 84907ACA0; Wed, 8 Jul 2020 07:13:11 +0000 (UTC) Date: Wed, 08 Jul 2020 09:13:10 +0200 Message-ID: From: Takashi Iwai To: "Gustavo A. R. Silva" Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ludovic Desroches , Nicolas Ferre Subject: Re: [PATCH] ALSA: Use fallthrough pseudo-keyword In-Reply-To: <20200707172847.GA27659@embeddedor> References: <20200707172847.GA27659@embeddedor> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 Jul 2020 19:28:47 +0200, Gustavo A. R. Silva wrote: > --- a/sound/isa/msnd/msnd_pinnacle_mixer.c > +++ b/sound/isa/msnd/msnd_pinnacle_mixer.c > @@ -219,8 +219,7 @@ static int snd_msndmix_set(struct snd_msnd *dev, int d, int left, int right) > case MSND_MIXER_VOLUME: /* master volume */ > writew(wLeft, dev->SMA + SMA_wCurrMastVolLeft); > writew(wRight, dev->SMA + SMA_wCurrMastVolRight); > - /* fall through */ > - > + fallthrough; > case MSND_MIXER_AUX: /* aux pot control */ > /* scaled by master volume */ > /* fall through */ Any reason to leave this? thanks, Takashi