From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: pcm: potential uninitialized return values Date: Tue, 27 Mar 2018 15:21:20 +0200 Message-ID: References: <20180327130752.GA31841@mwanda> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20180327130752.GA31841@mwanda> Sender: linux-kernel-owner@vger.kernel.org To: Dan Carpenter Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Sakamoto , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Tue, 27 Mar 2018 15:07:52 +0200, Dan Carpenter wrote: > > Smatch complains that "tmp" can be uninitialized if we do a zero size > write. > > Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write") > Signed-off-by: Dan Carpenter Thanks, that's an oversight indeed. Applied now. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Date: Tue, 27 Mar 2018 13:21:20 +0000 Subject: Re: [PATCH] ALSA: pcm: potential uninitialized return values Message-Id: List-Id: References: <20180327130752.GA31841@mwanda> In-Reply-To: <20180327130752.GA31841@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Sakamoto , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, 27 Mar 2018 15:07:52 +0200, Dan Carpenter wrote: > > Smatch complains that "tmp" can be uninitialized if we do a zero size > write. > > Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write") > Signed-off-by: Dan Carpenter Thanks, that's an oversight indeed. Applied now. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753083AbeC0NVY (ORCPT ); Tue, 27 Mar 2018 09:21:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:54111 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752462AbeC0NVX (ORCPT ); Tue, 27 Mar 2018 09:21:23 -0400 Date: Tue, 27 Mar 2018 15:21:20 +0200 Message-ID: From: Takashi Iwai To: "Dan Carpenter" Cc: , "Jaroslav Kysela" , "Takashi Sakamoto" , , Subject: Re: [PATCH] ALSA: pcm: potential uninitialized return values In-Reply-To: <20180327130752.GA31841@mwanda> References: <20180327130752.GA31841@mwanda> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Mar 2018 15:07:52 +0200, Dan Carpenter wrote: > > Smatch complains that "tmp" can be uninitialized if we do a zero size > write. > > Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write") > Signed-off-by: Dan Carpenter Thanks, that's an oversight indeed. Applied now. Takashi