From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v3 4/5] ALSA - hda: Add support for parsing
	new HDA capabilities
Date: Thu, 04 Aug 2016 07:46:10 +0200
Message-ID: <s5htwf1rsrh.wl-tiwai@suse.de>
References: <1470240374-20018-1-git-send-email-vinod.koul@intel.com>
 <1470240374-20018-5-git-send-email-vinod.koul@intel.com>
 <s5hinvh96j3.wl-tiwai@suse.de> <20160804020059.GA9681@localhost>
 <20160804055133.GB9681@localhost>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id C41102656F3
 for <alsa-devel@alsa-project.org>; Thu,  4 Aug 2016 07:46:10 +0200 (CEST)
In-Reply-To: <20160804055133.GB9681@localhost>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, patches.audio@intel.com, Hardik T Shah <hardik.t.shah@intel.com>, Guneshwor Singh <guneshwor.o.singh@intel.com>, liam.r.girdwood@linux.intel.com, broonie@kernel.org
List-Id: alsa-devel@alsa-project.org

On Thu, 04 Aug 2016 07:51:34 +0200,
Vinod Koul wrote:
> 
> On Thu, Aug 04, 2016 at 07:30:59AM +0530, Vinod Koul wrote:
> > > > +
> > > > +#ifdef CONFIG_X86
> > > > +	if ((bus->ppcap && boot_cpu_has(X86_FEATURE_ART)))
> > > 
> > > Superfluous parentheses.
> > > Also, don't we need to include asm/cpufeature.h?
> > 
> > Its somehow included, I will check that part as well
> 
> And didnt find how :(
> 
> Btw we include asm/pgtable.h which uses boot_cpu_has() macro.
> So somehow it is getting included.
> 
> Do you want this be explicitly included?

Yes, it's safer.


Takashi