From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH v3 0/3] conf: topology: Add the conf for SKL-rt286
Date: Thu, 21 Apr 2016 13:02:33 +0200 [thread overview]
Message-ID: <s5htwivdy2e.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160421105304.GN2274@localhost>
On Thu, 21 Apr 2016 12:53:04 +0200,
Vinod Koul wrote:
>
> On Thu, Apr 21, 2016 at 09:19:56AM +0200, Takashi Iwai wrote:
> > On Thu, 21 Apr 2016 08:27:35 +0200,
> > Vinod Koul wrote:
> > >
> > > This series adds SKL-i2c conf for simple PCM topology graph
> > >
> > > Changes in v3:
> > >
> > > - remove bin blobs, now they are generated in install step
> >
> > This isn't good in general. Usually all installed files are generated
> > in the normal make step, and make-install only copies them. There are
> > a few reasons:
> > - Invoking a random program as root is a security risk.
> > - This may create a file by root in the working directory, and either
> > it's not always possible (e.g. on NFS) or it may be left undeletable
> > after make install.
>
> Right, that is good point indeed.
>
> So what is your suggestion then?
Just put the normal make rule and generate it at the normal make
step (only when needed).
Takashi
next prev parent reply other threads:[~2016-04-21 11:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 6:27 [PATCH v3 0/3] conf: topology: Add the conf for SKL-rt286 Vinod Koul
2016-04-21 6:27 ` [PATCH v3 1/3] conf: topology: Add Skylake i2s conf Vinod Koul
2016-04-21 7:22 ` Takashi Iwai
2016-04-21 10:54 ` Vinod Koul
2016-04-21 6:27 ` [PATCH v3 2/3] Add u8 in type_compat.h Vinod Koul
2016-04-21 6:27 ` [PATCH v3 3/3] conf: topology: Generate Private data binary blobs Vinod Koul
2016-04-21 7:23 ` Takashi Iwai
2016-04-21 10:56 ` Vinod Koul
2016-04-21 11:00 ` Takashi Iwai
2016-04-22 3:16 ` Vinod Koul
2016-04-21 7:19 ` [PATCH v3 0/3] conf: topology: Add the conf for SKL-rt286 Takashi Iwai
2016-04-21 10:53 ` Vinod Koul
2016-04-21 11:02 ` Takashi Iwai [this message]
2016-04-22 3:14 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htwivdy2e.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.