From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached Date: Thu, 30 Jul 2015 17:57:49 +0200 Message-ID: References: <20150730004937.GA3133@thunk.org> <20150730013912.GA4068@thunk.org> <20150730144002.GY16722@phenom.ffwll.local> <20150730153228.GA15113@thunk.org> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150730153228.GA15113@thunk.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Theodore Ts'o Cc: Ander Conselvan de Oliveira , intel-gfx , Linux Kernel Mailing List , DRI , Daniel Vetter , Linus Torvalds List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAzMCBKdWwgMjAxNSAxNzozMjoyOCArMDIwMCwKVGhlb2RvcmUgVHMnbyB3cm90ZToK PiAKPiBPbiBUaHUsIEp1bCAzMCwgMjAxNSBhdCAwNDo0MDowMlBNICswMjAwLCBEYW5pZWwgVmV0 dGVyIHdyb3RlOgo+ID4gT24gV2VkLCBKdWwgMjksIDIwMTUgYXQgMTA6MTg6MTZQTSAtMDcwMCwg TGludXMgVG9ydmFsZHMgd3JvdGU6Cj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19o ZWxwZXIuYyB8IDggKysrKystLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMo KyksIDMgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2RybV9hdG9taWNfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxw ZXIuYwo+ID4gPiBpbmRleCA1YjU5ZDVhZDdkMWMuLmFhYzIxMjI5N2I0OSAxMDA2NDQKPiA+ID4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiA+ID4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiA+ID4gQEAgLTIzMCwxMCArMjMwLDEy IEBAIHVwZGF0ZV9jb25uZWN0b3Jfcm91dGluZyhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3Rh dGUsIGludCBjb25uX2lkeCkKPiA+ID4gIAl9Cj4gPiA+ICAKPiA+ID4gIAljb25uZWN0b3Jfc3Rh dGUtPmJlc3RfZW5jb2RlciA9IG5ld19lbmNvZGVyOwo+ID4gPiAtCWlkeCA9IGRybV9jcnRjX2lu ZGV4KGNvbm5lY3Rvcl9zdGF0ZS0+Y3J0Yyk7Cj4gPiA+ICsJaWYgKGNvbm5lY3Rvcl9zdGF0ZS0+ Y3J0Yykgewo+ID4gPiArCQlpZHggPSBkcm1fY3J0Y19pbmRleChjb25uZWN0b3Jfc3RhdGUtPmNy dGMpOwo+ID4gPiAgCj4gPiA+IC0JY3J0Y19zdGF0ZSA9IHN0YXRlLT5jcnRjX3N0YXRlc1tpZHhd Owo+ID4gPiAtCWNydGNfc3RhdGUtPm1vZGVfY2hhbmdlZCA9IHRydWU7Cj4gPiA+ICsJCWNydGNf c3RhdGUgPSBzdGF0ZS0+Y3J0Y19zdGF0ZXNbaWR4XTsKPiA+ID4gKwkJY3J0Y19zdGF0ZS0+bW9k ZV9jaGFuZ2VkID0gdHJ1ZTsKPiA+ID4gKwl9Cj4gPiAKPiA+IFRoaXMgc2hvdWxkbid0IGhhcHBl biBzaW5jZSBpZiBpdCBkb2VzIHdlIGVuZGVkIHVwIHN0ZWFsaW5nIHRoZSBlbmNvZGVyCj4gPiBm cm9tIHRoZSBjb25uZWN0b3IgaXRzZWxmICh3ZSBkbyBjaGVjayBmb3IgY29ubmVjdG9yX3N0YXRl LT5jcnRjIGVhcmxpZXIpCj4gPiBhbmQgdGhhdCB3b3VsZCBiZSBhIGJ1Zy4gSSBoYXZlbid0IGZp Z3VyZWQgb3V0IGEgcHJlY2lzZSB0aGVvcnkgYnV0IG15Cj4gPiBndWVzcyBpcyBvbiB0aGUgYmVz dF9lbmNvZGVyIHNlbGVjdGlvbiwgYW5kIGluZGVlZCBkcCBtc3QgZW5jb2Rlcgo+ID4gc2VsZWN0 aW9uIHNlZW1zIHRvIGhhdmUgZ29uZSBiZWxseSB1cCBpbiA0LjIgd2l0aCB0aGUgYmlzZWN0ZWQg Y29tbWl0Lgo+IAo+IFdlbGwsIEkganVzdCB0ZXN0ZWQgTGludXMncyBwYXRjaCBhbmQgaXQgd29y a3MuCj4gCj4gQlRXLCBpcyB0aGVyZSBhbnkgY2hhbmNlIHRoYXQgSSBjYW4gc3VzcGVuZCBteSBs YXB0b3AsIGFuZCB0aGVuIG1vdmUKPiBpdCBmcm9tIG15IGRvY2tpbmcgc3RhdGlvbiBhdCBob21l ICh3aGVyZSBJIGhhdmUgYSBEZWxsIDMwIiBkaXNwbGF5KQo+IHRvIG15IGRvY2tpbmcgc3RhdGlv biBhdCB3b3JrICh3aGVyZSBJIGhhdmUgYSBEZWxsIDI0IiBkaXNwbGF5KSwgYW5kCj4gYWN0dWFs bHkgaGF2ZSB0aGUgbmV3IG1vbml0b3IgYmUgZGV0ZWN0ZWQ/ICBGb3IgYXQgbGVhc3QgdGhlIHBh c3QKPiB5ZWFyLCBJIGhhdmUgdG8gcmVib290IGluIG9yZGVyIHRvIGJlIGFibGUgdG8gdXNlIHRo ZSBleHRlcm5hbAo+IG1vbml0b3I/ICBUaGlzIHVzZWQgdG8gd29yaywgYnV0IGl0J3MgYmVlbiBh IHZlcnkgbG9uZy1zdGFuZGluZwo+IHJlZ3Jlc3Npb24uICBJIHVuZHJzdGFuZCB0aGF0IE11bHRp LXN0cmVhbSBEUCBpcyBhIGV2aWwgaG9ycmlibGUgaGFjaywKPiBhbmQgc3VwcG9ydGluZyBpdCBp cyBwYWluZnVsLCBidXQgdGhpcyB1c2VkIHRvIHdvcmssIGFuZCBpdCBoYXNuJ3QgaW4KPiBhIGxv bmcgdGltZS4gIDotKAoKUmVsZXZhbnQgd2l0aCB0aGlzPwogICBodHRwczovL2J1Z3MuZnJlZWRl c2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD04OTU4OQoKSSB3YW50ZWQgdG8gY2hlY2sgdGhpcyBi eSBteXNlbGYsIHRvbywgYXMgdGhlIHNhbWUgYnVnIHdhcyByZXBvcnRlZCB0bwpvcGVuU1VTRSBi dWd6aWxsYSwgYnV0IEkgaGFkIG5vIGhhcmR3YXJlIHNob3dpbmcgaXQuCgoKVGFrYXNoaQpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752422AbbG3P5y (ORCPT ); Thu, 30 Jul 2015 11:57:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:45436 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750894AbbG3P5x (ORCPT ); Thu, 30 Jul 2015 11:57:53 -0400 Date: Thu, 30 Jul 2015 17:57:49 +0200 Message-ID: From: Takashi Iwai To: "Theodore Ts'o" Cc: Linus Torvalds , intel-gfx , DRI , Daniel Vetter , Mani Nikula , Ander Conselvan de Oliveira , Linux Kernel Mailing List Subject: Re: [Intel-gfx] [REGRESSION] Re: i915 driver crashes on T540p if docking station attached In-Reply-To: <20150730153228.GA15113@thunk.org> References: <20150730004937.GA3133@thunk.org> <20150730013912.GA4068@thunk.org> <20150730144002.GY16722@phenom.ffwll.local> <20150730153228.GA15113@thunk.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Jul 2015 17:32:28 +0200, Theodore Ts'o wrote: > > On Thu, Jul 30, 2015 at 04:40:02PM +0200, Daniel Vetter wrote: > > On Wed, Jul 29, 2015 at 10:18:16PM -0700, Linus Torvalds wrote: > > > drivers/gpu/drm/drm_atomic_helper.c | 8 +++++--- > > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > > > index 5b59d5ad7d1c..aac212297b49 100644 > > > --- a/drivers/gpu/drm/drm_atomic_helper.c > > > +++ b/drivers/gpu/drm/drm_atomic_helper.c > > > @@ -230,10 +230,12 @@ update_connector_routing(struct drm_atomic_state *state, int conn_idx) > > > } > > > > > > connector_state->best_encoder = new_encoder; > > > - idx = drm_crtc_index(connector_state->crtc); > > > + if (connector_state->crtc) { > > > + idx = drm_crtc_index(connector_state->crtc); > > > > > > - crtc_state = state->crtc_states[idx]; > > > - crtc_state->mode_changed = true; > > > + crtc_state = state->crtc_states[idx]; > > > + crtc_state->mode_changed = true; > > > + } > > > > This shouldn't happen since if it does we ended up stealing the encoder > > from the connector itself (we do check for connector_state->crtc earlier) > > and that would be a bug. I haven't figured out a precise theory but my > > guess is on the best_encoder selection, and indeed dp mst encoder > > selection seems to have gone belly up in 4.2 with the bisected commit. > > Well, I just tested Linus's patch and it works. > > BTW, is there any chance that I can suspend my laptop, and then move > it from my docking station at home (where I have a Dell 30" display) > to my docking station at work (where I have a Dell 24" display), and > actually have the new monitor be detected? For at least the past > year, I have to reboot in order to be able to use the external > monitor? This used to work, but it's been a very long-standing > regression. I undrstand that Multi-stream DP is a evil horrible hack, > and supporting it is painful, but this used to work, and it hasn't in > a long time. :-( Relevant with this? https://bugs.freedesktop.org/show_bug.cgi?id=89589 I wanted to check this by myself, too, as the same bug was reported to openSUSE bugzilla, but I had no hardware showing it. Takashi