From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [patch] sound: oss/sb_audio: cap value in sb201_audio_set_speed() Date: Sun, 18 Nov 2012 10:28:46 +0100 Message-ID: References: <20121117150857.GC19951@elgon.mountain> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 7BE04261599 for ; Sun, 18 Nov 2012 10:28:49 +0100 (CET) In-Reply-To: <20121117150857.GC19951@elgon.mountain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Dan Carpenter Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org List-Id: alsa-devel@alsa-project.org At Sat, 17 Nov 2012 18:08:57 +0300, Dan Carpenter wrote: > > We set "s" before we have capped "speed" so it could be the wrong value. > This could lead to a divide by zero bug. > > Signed-off-by: Dan Carpenter > --- > I fixed a similar bug in this file in Aug. I'm not sure how I missed > this one. I don't see any others I missed. Thanks, applied. Takashi > > diff --git a/sound/oss/sb_audio.c b/sound/oss/sb_audio.c > index b2b3c01..048439a 100644 > --- a/sound/oss/sb_audio.c > +++ b/sound/oss/sb_audio.c > @@ -442,7 +442,7 @@ static int sb201_audio_set_speed(int dev, int speed) > { > sb_devc *devc = audio_devs[dev]->devc; > int tmp; > - int s = speed * devc->channels; > + int s; > > if (speed > 0) > { > @@ -452,6 +452,7 @@ static int sb201_audio_set_speed(int dev, int speed) > speed = 44100; > if (devc->opened & OPEN_READ && speed > 15000) > speed = 15000; > + s = speed * devc->channels; > devc->tconst = (256 - ((1000000 + s / 2) / s)) & 0xff; > tmp = 256 - devc->tconst; > speed = ((1000000 + tmp / 2) / tmp) / devc->channels; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Date: Sun, 18 Nov 2012 09:28:46 +0000 Subject: Re: [patch] sound: oss/sb_audio: cap value in sb201_audio_set_speed() Message-Id: List-Id: References: <20121117150857.GC19951@elgon.mountain> In-Reply-To: <20121117150857.GC19951@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org At Sat, 17 Nov 2012 18:08:57 +0300, Dan Carpenter wrote: > > We set "s" before we have capped "speed" so it could be the wrong value. > This could lead to a divide by zero bug. > > Signed-off-by: Dan Carpenter > --- > I fixed a similar bug in this file in Aug. I'm not sure how I missed > this one. I don't see any others I missed. Thanks, applied. Takashi > > diff --git a/sound/oss/sb_audio.c b/sound/oss/sb_audio.c > index b2b3c01..048439a 100644 > --- a/sound/oss/sb_audio.c > +++ b/sound/oss/sb_audio.c > @@ -442,7 +442,7 @@ static int sb201_audio_set_speed(int dev, int speed) > { > sb_devc *devc = audio_devs[dev]->devc; > int tmp; > - int s = speed * devc->channels; > + int s; > > if (speed > 0) > { > @@ -452,6 +452,7 @@ static int sb201_audio_set_speed(int dev, int speed) > speed = 44100; > if (devc->opened & OPEN_READ && speed > 15000) > speed = 15000; > + s = speed * devc->channels; > devc->tconst = (256 - ((1000000 + s / 2) / s)) & 0xff; > tmp = 256 - devc->tconst; > speed = ((1000000 + tmp / 2) / tmp) / devc->channels; >