From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] pcm_oss: AFMT_S24_LE is set twice in
	return value
Date: Wed, 04 Feb 2009 18:26:34 +0100
Message-ID: <s5htz7a6rlh.wl%tiwai@suse.de>
References: <4989CD0F.50700@gmail.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (ns2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id 1AD0B1038DE
	for <alsa-devel@alsa-project.org>; Wed,  4 Feb 2009 18:26:35 +0100 (CET)
In-Reply-To: <4989CD0F.50700@gmail.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Roel Kluin <roel.kluin@gmail.com>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Wed, 04 Feb 2009 18:14:55 +0100,
Roel Kluin wrote:
> 
> vi sound/core/oss/pcm_oss.c +640
> #define AFMT_S24_LE      0x00008000
> #define AFMT_S24_BE      0x00010000
> 
> ---------------------->8----------------------8<-------------------
> AFMT_S24_LE is set twice in return value
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Thanks, applied now.


Takashi

> ---
> diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
> index e178366..0a1798e 100644
> --- a/sound/core/oss/pcm_oss.c
> +++ b/sound/core/oss/pcm_oss.c
> @@ -1767,7 +1767,7 @@ static int snd_pcm_oss_get_formats(struct snd_pcm_oss_file *pcm_oss_file)
>  		       AFMT_S8 | AFMT_U16_LE |
>  		       AFMT_U16_BE |
>  			AFMT_S32_LE | AFMT_S32_BE |
> -			AFMT_S24_LE | AFMT_S24_LE |
> +			AFMT_S24_LE | AFMT_S24_BE |
>  			AFMT_S24_PACKED;
>  	params = kmalloc(sizeof(*params), GFP_KERNEL);
>  	if (!params)
>