From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 5/19] ASoC 0.13 WM8750 codec driver Date: Fri, 02 Feb 2007 16:29:29 +0100 Message-ID: References: <1170427418.18082.134.camel@localhost.localdomain> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1170427418.18082.134.camel@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Liam Girdwood Cc: alsa-devel List-Id: alsa-devel@alsa-project.org At Fri, 02 Feb 2007 14:43:38 +0000, Liam Girdwood wrote: > > diff -r fc216dd0eb92 soc/codecs/wm8750.c > --- a/soc/codecs/wm8750.c Thu Feb 01 16:52:06 2007 +0100 > +++ b/soc/codecs/wm8750.c Wed Jan 31 16:43:17 2007 +0000 (snip) > +static struct workqueue_struct *wm8750_workq = NULL; I guess the normal schedule_delayed_work() is enough instead of own workq? Unless really frequent and heavy jobs, the global queue is more friendly to the system. Takashi ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642