Re: Midi name string in mpu401_uart not unique

[Takashi Iwai <tiwai@suse.de>]

At Fri, 31 Mar 2006 11:02:37 +0100,
Alan Horstmann wrote:
> 
> [1  <text/plain; iso-8859-1 (7bit)>]
> On Thursday 30 March 2006 18:53, you wrote:
> > At Thu, 30 Mar 2006 18:45:23 +0100,
> > Alan Horstmann wrote:
> 
> > > On Thursday 30 March 2006 12:04, you wrote:
> > > >
> > > > Instead of adding a new argument to snd_mpu401_uart_new, the caller
> > > > can overwrite the string after creating the instace.
> > > >
> > > > 	snd_mpu401_uart_new(card, device, type, ..., &rmidi);
> > > > 	snprintf(rmidi->name, sizeof(rmidi->name),
> > > > 		"MIDI Name As I Like %d", card->number);
> > > >
> > > > Then the change would be less intrusive.
> > > >
> > > > Or am I missing something else?
> > >
> > > Sounds a lot simpler -just involving the driver only; I will try this
> > > later. In the mpu-names.diff midi names were added to
> > > snd_ice1712_card_info to be used in the name string.  Is that still a
> > > reasonable thing to do, or is there a better place, given that the
> > > different sub-vendors might have different requirements?
> >
> > That addition looks OK to me.  What I don't want is to change the
> > existing API if there is a simple solution.
> >
> > > Bearing in mind Clemens' comments, is there any value in improving the
> > > name given by mpu401_uart_new when using ->shortname, as in the diff, by
> > > adding card and device numbers?
> >
> > Maybe the order of "CARD DEVICE" like "DMX6fire WaveTable" is better?
> > Just a matter of taste, though...
> 
> Would it be acceptable to add card, device to ->shortname in mpu401_uart as 
> attached:
> 
> mpu401_uart.c-add-to-shortname.patch
> 
> Add card and device numbers to portnames generated from ->shortnames by 
> snd_mpu401_uart_new.
> 
> Signed-off-by: Alan Horstmann <gineera@aspect135.co.uk>

Thanks for the patch.  But I don't want to change that part at all.
It may break other stuff what you've not tested.

Just change the ice1712 stuff, instead.


Takashi

> [2 mpu401_uart.c-add-to-shortname.patch <text/x-diff; iso-8859-1 (7bit)>]
> --- mpu401_uart-orig.c	2005-11-18 18:52:14.000000000 +0000
> +++ mpu401_uart.c	2006-03-31 10:33:33.000000000 +0100
> @@ -506,7 +506,7 @@
>  	mpu->irq = irq;
>  	mpu->irq_flags = irq_flags;
>  	if (card->shortname[0])
> -		snprintf(rmidi->name, sizeof(rmidi->name), "%s MIDI", card->shortname);
> +		snprintf(rmidi->name, sizeof(rmidi->name), "%s MIDI %d-%d", card->shortname, card->number, device);
>  	else
>  		sprintf(rmidi->name, "MPU-401 MIDI %d-%d", card->number, device);
>  	snd_rawmidi_set_ops(rmidi, SNDRV_RAWMIDI_STREAM_OUTPUT, &snd_mpu401_uart_output);


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642