From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: PATCH: Aureal vortex alsa-kernel.
Date: Mon, 26 Jan 2004 11:51:44 +0100
Sender: alsa-devel-admin@lists.sourceforge.net
Message-ID: <s5hu12jugn3.wl@alsa2.suse.de>
References: <1074989976.18361.42.camel@localhost>
	<s5hwu7fuhic.wl@alsa2.suse.de>
Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
Return-path: <alsa-devel-admin@lists.sourceforge.net>
In-Reply-To: <s5hwu7fuhic.wl@alsa2.suse.de>
Errors-To: alsa-devel-admin@lists.sourceforge.net
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Post: <mailto:alsa-devel@lists.sourceforge.net>
List-Help: <mailto:alsa-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=subscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=alsa-devel>
To: manuel.jander@mat.utfsm.cl
Cc: alsa-devel@lists.sourceforge.net
List-Id: alsa-devel@alsa-project.org

At Mon, 26 Jan 2004 11:32:59 +0100,
I wrote:
> 
> Hi Manuel,
> 
> At Sat, 24 Jan 2004 20:19:36 -0400,
> Manuel Jander wrote:
> > 
> > Hi,
> > 
> > To the ALSA tree maintainers:
> > 
> > I have uploaded a patch which moves the current Aureal driver into the
> > alsa-kernel/ directory. Please apply it, because many people are waiting
> > for it since a long time, and the driver is working stable. I really
> > need this to be done, please.
> > 
> > Patch location:
> > http://galadriel.mat.utfsm.cl/~mjander/aureal/alsa/patch.gz
> > (about 100KiB)
> 
> oh i wanted to ask you today the exactly same thing, but you must have
> seen it via a tarot card :)
> 
> the patch looks nice, but please clean up the codes a bit more before
> merging to alsa-kernel, namely,
> 
> - use the correct tab width (8) and indentation.
>   e.g. the open brace are usually put in the next line.
> 
> - remove the unnecessary (and skeptical) codes such as disasembling or
>   c++ codes from somewhere else.  only your own codes, please.
> 
> - put GPL notice to each file.
>   ok, we don't need it for au8810.c & co...
> 
> - add EXPORT_NO_SYMBOLS; to the main file of alsa-driver (not
>   alsa-kernel).  apparently we have forgotten that.

also, give the patch for ALSA-Configuration.txt, too. 


Takashi


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn