Re: Patch: combining the maestro drivers

[Takashi Iwai <tiwai@suse.de>]

At Tue, 15 Jul 2003 00:16:33 -0500,
Warren Turkal wrote:
> 
> On Wednesday 09 July 2003 07:38 am, Takashi Iwai wrote:
> > At Wed, 9 Jul 2003 00:34:46 -0500,
> >
> > Warren Turkal wrote:
> > > Is there any work being done to join up some of the common stuff (defines
> > > seem to be functionally identical in a lot of the ESS pci drivers) in the
> > > ESS drivers?
> >
> > no, at least i'm not working on it.
> > of course, patches are always welcome :)
> >
> >
> > Takashi
> >
> 
> If you are seriously accepting patches, this starts the process of combining 
> common defines. This patch takes care of the main PCI configuration 
> registers.
 
yeah, i'm always serious :)
no, apart from kidding, the patch is always appreciated.

> It creates a file <kernel_dir>/sound/pci/maestro.h that holds the new defines. 
> I copied the defines from the maestro3.h over and commented them out, but the 
> names of the defines in es1968.c are much cleaner. I believe they will be the 
> format for naming I follow.
> 
> This is a minimal patch to start the integration of these drivers. The 
> register setups are very similar and I plan to combine as many of the defines 
> as it is sane to do so. The rest of the defines will remain in the respective 
> source files.
 
the header file looks fine.
the KDATA_* stuff may be in maestro3, because it is dependent on the
DSP micro code, which isn't present on maestro2.


thanks,

Takashi


-------------------------------------------------------
This SF.Net email sponsored by: Parasoft
Error proof Web apps, automate testing & more.
Download & eval WebKing and get a free book.
www.parasoft.com/bulletproofapps1