Re: oops while unloading snd-intel8x0

[Takashi Iwai <tiwai@suse.de>]

Hi Enrik,

At Fri, 10 Jan 2003 13:37:32 +0100,
Enrik Berkhan wrote:
> 
> Hi,
> 
> At Tue, 10 Dec 2002 08:39:35 -0800, Takashi Iwai wrote:
> > At Tue, 10 Dec 2002 13:50:31 +0100, Christian Guggenberger wrote:
> > > I get following oops while unloading snd-intel8x0 on a Dell Optiplex 260
> > hmm, it's a new type of oops, which i've never seen.
> 
> I had the same problem using a Gericom Frontman (SiS 7012). It turned out
> that unregistering the joystick_driver while no joystick had been found
> on init caused the oops.

Ah, thanks for pointing out!

> Proposed patch:
> 
> --- intel8x0.c.orig	Mon Oct 28 12:56:35 2002
> +++ intel8x0.c	Thu Jan  9 13:13:21 2003
> @@ -1783,6 +1783,9 @@
>  	} while (time_after_eq(end_time, jiffies));
>  
>        __ok3:      
> +	if (chip->device_type == DEVICE_SIS) {
> +		iputword(chip, 0x4c, igetword(chip, 0x4c) | 1);
> +	}
>        	return 0;
>  }
>  

what initializes this?
does it fix the silent problem on sis7012?


other changes look fine (printk would be snd_printdd only for debug
messages).


Takashi


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com