From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4DF4C433DB for ; Tue, 12 Jan 2021 08:23:48 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F27EC22D2C for ; Tue, 12 Jan 2021 08:23:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F27EC22D2C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 513C516B2; Tue, 12 Jan 2021 09:22:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 513C516B2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1610439821; bh=TI6V/WYTwrvlC5FU6HrzyDpN71p8oVe4gtm7skR5QRQ=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JoTBP7ung+PYmw6DvpmYX02c7OlQYB3AhAb1FuPXqJj8cniTT4L5vVqaCX4BHYEZm fDcaiHqt0ZgtlWQujsjftpuDTyLHTiVM1zhkFjnGAl2TW0i3x2KnHl2i6JW72ixooS QG987C9yI5vx8cdW3L8G2DW0XCQ/OP5+wbTcIHYk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B7F57F80249; Tue, 12 Jan 2021 09:22:50 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1E90EF8025E; Tue, 12 Jan 2021 09:22:48 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 89F8FF800EB for ; Tue, 12 Jan 2021 09:22:39 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 89F8FF800EB X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 91D36AC8F; Tue, 12 Jan 2021 08:22:38 +0000 (UTC) Date: Tue, 12 Jan 2021 09:22:38 +0100 Message-ID: From: Takashi Iwai To: Peter Geis Subject: Re: [PATCH v2 0/2] fix tegra-hda on tegra30 devices In-Reply-To: <20210108135913.2421585-1-pgwipeout@gmail.com> References: <20210108135913.2421585-1-pgwipeout@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Prashant Gaikwad , Sameer Pujar , Stephen Boyd , linux-kernel@vger.kernel.org, Michael Turquette , linux-clk@vger.kernel.org, Takashi Iwai , Jonathan Hunter , Thierry Reding , linux-tegra@vger.kernel.org, Mohan Kumar , Peter De Schrijver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 08 Jan 2021 14:59:11 +0100, Peter Geis wrote: > > The following patches fix tegra-hda on legacy tegra devices. > Two issues were discovered preventing tegra-hda from functioning: > -The hda clocks on tegra30 were assigned to clk_m and running at too low > of a rate to function. > -The tegra-hda encounters an input/output error when opening a stream. > > Since the only mainline device that used tegra-hda until recently was the > t124, it is unknown exactly when this was broken. Fortunately a recent > patch was submitted that fixed the issue only on t194 devices. We can > apply it to the tegra30-hda device to resolve the issue across the board. > Note that downstream devices used the spdif device instead of hda for hdmi > audio. The spdif device lacks a driver on mainline. > > -Checkpatch seems to have issues finding [1], but git show has no issue. > [1] commit 60019d8c650d ("ALSA: hda/tegra: workaround playback failure on > Tegra194") > > Changelog: > > v2: > -Added ack and reviewed-by from Jon > -Updated fix to apply to tegra30-hda vice universally (Thanks Jon) > -Updated commit to include comments from hardware team (Thanks Sameer) > -Cleaned up commit messages > > Peter Geis (2): > clk: tegra30: Add hda clock default rates to clock driver > ALSA: hda/tegra: fix tegra-hda on tegra30 soc Shall I apply both patches via sound git tree? Or, if you want to take through clk tree, let me know. In that case, feel free to take my ack: Acked-by: Takashi Iwai thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 473CCC433E0 for ; Tue, 12 Jan 2021 08:23:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFB7222D58 for ; Tue, 12 Jan 2021 08:23:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732171AbhALIXV (ORCPT ); Tue, 12 Jan 2021 03:23:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:34248 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728262AbhALIXU (ORCPT ); Tue, 12 Jan 2021 03:23:20 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 91D36AC8F; Tue, 12 Jan 2021 08:22:38 +0000 (UTC) Date: Tue, 12 Jan 2021 09:22:38 +0100 Message-ID: From: Takashi Iwai To: Peter Geis Cc: Michael Turquette , Stephen Boyd , Peter De Schrijver , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Jaroslav Kysela , Takashi Iwai , Sameer Pujar , Mohan Kumar , linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2 0/2] fix tegra-hda on tegra30 devices In-Reply-To: <20210108135913.2421585-1-pgwipeout@gmail.com> References: <20210108135913.2421585-1-pgwipeout@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Fri, 08 Jan 2021 14:59:11 +0100, Peter Geis wrote: > > The following patches fix tegra-hda on legacy tegra devices. > Two issues were discovered preventing tegra-hda from functioning: > -The hda clocks on tegra30 were assigned to clk_m and running at too low > of a rate to function. > -The tegra-hda encounters an input/output error when opening a stream. > > Since the only mainline device that used tegra-hda until recently was the > t124, it is unknown exactly when this was broken. Fortunately a recent > patch was submitted that fixed the issue only on t194 devices. We can > apply it to the tegra30-hda device to resolve the issue across the board. > Note that downstream devices used the spdif device instead of hda for hdmi > audio. The spdif device lacks a driver on mainline. > > -Checkpatch seems to have issues finding [1], but git show has no issue. > [1] commit 60019d8c650d ("ALSA: hda/tegra: workaround playback failure on > Tegra194") > > Changelog: > > v2: > -Added ack and reviewed-by from Jon > -Updated fix to apply to tegra30-hda vice universally (Thanks Jon) > -Updated commit to include comments from hardware team (Thanks Sameer) > -Cleaned up commit messages > > Peter Geis (2): > clk: tegra30: Add hda clock default rates to clock driver > ALSA: hda/tegra: fix tegra-hda on tegra30 soc Shall I apply both patches via sound git tree? Or, if you want to take through clk tree, let me know. In that case, feel free to take my ack: Acked-by: Takashi Iwai thanks, Takashi