From: Takashi Iwai <tiwai@suse.de>
To: jeronimo@borque.com.ar
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda - Fixes inverted Conexant GPIO mic mute led
Date: Thu, 15 Aug 2019 07:58:32 +0200 [thread overview]
Message-ID: <s5hv9uz9dh3.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190815013824.13373-1-jeronimo@borque.com.ar>
On Thu, 15 Aug 2019 03:38:24 +0200,
<jeronimo@borque.com.ar> wrote:
>
> From: Jeronimo Borque <jeronimo@borque.com.ar>
>
> "enabled" parameter historically referred to the device input or
> output, not to the led indicator. After the changes added with the
> led helper functions the mic mute led logic refers to the led and not
> to the mic input which caused led indicator to be negated (Mic mute
> led was on when the input enabled) Fixing it in the call to
> cxt_update_gpio_led at the cxt_gpio_micmute_update hook.
> Maybe more changes are required to be consistent everywhere.
>
> Signed-off-by: Jeronimo Borque <jeronimo@borque.com.ar>
Could you check which value you have in "Mic Mute-LED Mode" mixer
element? I guess it's "Follow Mute". If so, change it to "Follow
Capture".
If this works, it means that the driver works as expected but the
problem is only about the default value. The default value set in the
generic parser is based on other machine's standard (LED on at mic
off), while some machines might expect differently. On such machines,
we need to set the different value initially in the quirk fixup.
thanks,
Takashi
next prev parent reply other threads:[~2019-08-15 5:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 1:38 [PATCH] ALSA: hda - Fixes inverted Conexant GPIO mic mute led jeronimo
2019-08-15 5:58 ` Takashi Iwai [this message]
2019-08-15 16:33 ` Jerónimo Borque
2019-08-15 17:06 ` Takashi Iwai
2019-08-15 23:08 ` Jerónimo Borque
2019-08-16 7:11 ` Takashi Iwai
2019-08-18 21:23 ` [PATCH v2] " jeronimo
2019-08-19 0:01 ` Jerónimo Borque
2019-08-19 1:35 ` [PATCH v3] " jeronimo
2019-08-19 17:42 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hv9uz9dh3.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=jeronimo@borque.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.