From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 3/3] ASoC: Intel: cht_bsw_rt5672: fix card name Date: Fri, 08 Sep 2017 10:16:23 +0200 Message-ID: References: <20170908011256.7706-1-pierre-louis.bossart@linux.intel.com> <20170908011256.7706-4-pierre-louis.bossart@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id BA14A266A89 for ; Fri, 8 Sep 2017 10:16:24 +0200 (CEST) In-Reply-To: <20170908011256.7706-4-pierre-louis.bossart@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart Cc: vinod.koul@intel.com, bardliao@realtek.com, alsa-devel@alsa-project.org, broonie@kernel.org List-Id: alsa-devel@alsa-project.org On Fri, 08 Sep 2017 03:12:56 +0200, Pierre-Louis Bossart wrote: > > For now reason the current card name is a ridiculous > 'cherrytrailcraudio'. This isn't very useful or self-explanatory, > change to driver name cht-bsw-rt5672. One bonus by this change would be to avoid inconsistent names by the driver's name string size. Since it's 16 bytes including \0, the name is shortened as cherrytrailcrau or such in some fields. With the new name this shouldn't happen. In anyway, Reviewed-by: Takashi Iwai thanks, Takashi