From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const Date: Tue, 30 May 2017 10:54:22 +0200 Message-ID: References: <1495896375-30855-1-git-send-email-bhumirks@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1495896375-30855-1-git-send-email-bhumirks@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Bhumika Goyal Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, broonie@kernel.org, clemens@ladisch.de, julia.lawall@lip6.fr, linuxppc-dev@lists.ozlabs.org, perex@perex.cz, johannes@sipsolutions.net, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Sat, 27 May 2017 16:46:15 +0200, Bhumika Goyal wrote: > > Declare snd_kcontrol_new structures as const as they are only passed an > argument to the function snd_ctl_new1. This argument is of type const, > so snd_kcontrol_new structures having this property can be made const. > Done using Coccinelle: > > @r disable optional_qualifier@ > identifier x; > position p; > @@ > static struct snd_kcontrol_new x@p={...}; > > @ok@ > identifier r.x; > position p; > @@ > snd_ctl_new1(&x@p,...) > > @bad@ > position p != {r.p,ok.p}; > identifier r.x; > @@ > x@p > > @depends on !bad disable optional_qualifier@ > identifier r.x; > @@ > +const > struct snd_kcontrol_new x; > > Cross compiled these files: > sound/aoa/codecs/tas.c - powerpc > sound/mips/{hal2.c/sgio2audio.c} - mips > sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc > sound/soc/sh/siu_dai.c - sh > Could not find an architecture to compile sound/sh/aica.c. > > Signed-off-by: Bhumika Goyal Applied now, as it looks safe enough. But I prefer splitting to individual patches, so please try to do that at the next time. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3wcS8j5xZLzDq5x for ; Tue, 30 May 2017 18:54:29 +1000 (AEST) Date: Tue, 30 May 2017 10:54:22 +0200 Message-ID: From: Takashi Iwai To: "Bhumika Goyal" Cc: , , , , , , , , Subject: Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const In-Reply-To: <1495896375-30855-1-git-send-email-bhumirks@gmail.com> References: <1495896375-30855-1-git-send-email-bhumirks@gmail.com> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 27 May 2017 16:46:15 +0200, Bhumika Goyal wrote: > > Declare snd_kcontrol_new structures as const as they are only passed an > argument to the function snd_ctl_new1. This argument is of type const, > so snd_kcontrol_new structures having this property can be made const. > Done using Coccinelle: > > @r disable optional_qualifier@ > identifier x; > position p; > @@ > static struct snd_kcontrol_new x@p={...}; > > @ok@ > identifier r.x; > position p; > @@ > snd_ctl_new1(&x@p,...) > > @bad@ > position p != {r.p,ok.p}; > identifier r.x; > @@ > x@p > > @depends on !bad disable optional_qualifier@ > identifier r.x; > @@ > +const > struct snd_kcontrol_new x; > > Cross compiled these files: > sound/aoa/codecs/tas.c - powerpc > sound/mips/{hal2.c/sgio2audio.c} - mips > sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc > sound/soc/sh/siu_dai.c - sh > Could not find an architecture to compile sound/sh/aica.c. > > Signed-off-by: Bhumika Goyal Applied now, as it looks safe enough. But I prefer splitting to individual patches, so please try to do that at the next time. thanks, Takashi