From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 1/1] ASoC: core: Do not print an actual error when deferring probe Date: Wed, 18 May 2016 18:57:50 +0200 Message-ID: References: <1463578889-13709-1-git-send-email-alexander.stein@systec-electronic.com> <209086304.1BTKYSBN0B@ws-stein> <20160518152820.GN8104@sirena.org.uk> <1574831.WL8kGhHEjA@ws-stein> <20160518162154.GP8104@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id A41572612D0 for ; Wed, 18 May 2016 18:57:51 +0200 (CEST) In-Reply-To: <20160518162154.GP8104@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Liam Girdwood , Alexander Stein List-Id: alsa-devel@alsa-project.org On Wed, 18 May 2016 18:21:54 +0200, Mark Brown wrote: > > On Wed, May 18, 2016 at 05:50:50PM +0200, Alexander Stein wrote: > > > My first idea was to use dev_dbg() but that actualy remove that message at > > all, unless dynamic debug is used, so I went with dev_notice. It's still > > there, but does not clobber quiet boot log, nor some sophisticated kernel log > > parser as journalctl which prints errors in red color. > > It's just shifting the problem around... it sounds like for your use > case suppressing the messages until we finish kernel boot would deal > with most of the issue in a far more general fashion. It comes to the question whether this message must be shown verbosely as an error at all. EPROBE_DEFER is usually a mechanism for the delayed probe, and it doesn't indicate an error per se. dev_err() is, OTOH, for real errors that have to be notified to user inevitably. That's why "quiet" boot option still shows it. Takashi