From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: linux-4.6-rc4/sound/pci/ens1370.c:1551: possible bad expression ? Date: Tue, 19 Apr 2016 15:31:54 +0200 Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 1296A2604D6 for ; Tue, 19 Apr 2016 15:31:56 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: David Binderman Cc: "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" List-Id: alsa-devel@alsa-project.org T24gTW9uLCAxOCBBcHIgMjAxNiAxODoxNzo1OCArMDIwMCwKRGF2aWQgQmluZGVybWFuIHdyb3Rl Ogo+IAo+IEhlbGxvIHRoZXJlLAo+IAo+IFtsaW51eC00LjYtcmM0L3NvdW5kL3BjaS9lbnMxMzcw LmM6MTU1MV06IChzdHlsZSkgRXhwcmVzc2lvbiAnKFggJiAweGYwMDAwKT49IDB4NCcgaXMgYWx3 YXlzIGZhbHNlLgo+IAo+IFNvdXJjZSBjb2RlIGlzCj4gCj4gwqDCoMKgIGlmICgoZW5zb25pcS0+ Y3RybCAmIEVTXzEzNzFfR1BJT19PVVRNKT49IDQpCj4gwqDCoMKgwqDCoMKgwqAgdmFsID0gMTsK ClRoYW5rcyBmb3IgdGhlIHJlcG9ydC4gIEl0J3MgZml4ZWQgbm93IGJ5IHRoZSBwYXRjaCBiZWxv dy4KCgpUYWthc2hpCgotLSA4PCAtLQpGcm9tOiBUYWthc2hpIEl3YWkgPHRpd2FpQHN1c2UuZGU+ ClN1YmplY3Q6IFtQQVRDSF0gQUxTQTogZW5zMTM3MTogRml4ICJMaW5lIEluLT5SZWFyIE91dCBT d2l0Y2giIGNvbnRyb2wKClRoZSAiTGluZSBJbi0+UmVhciBPdXQgU3dpdGNoIiBjb250cm9sIG9u IGVuczEzNzEgZHJpdmVyIHJldHVybnMgYQpib2d1cyB2YWx1ZSwgYWx3YXlzIHRydWUsIGFzIGl0 cyBjaGVjayBpcyB0b3RhbGx5IGJyb2tlbi4gIEZpeCBpdCB0bwpjaGVjayB0aGUgcHJvcGVyIEdQ SU8gYml0IG1hc2suCgpSZXBvcnRlZC1ieTogRGF2aWQgQmluZGVybWFuIDxkY2IzMTRAaG90bWFp bC5jb20+ClNpZ25lZC1vZmYtYnk6IFRha2FzaGkgSXdhaSA8dGl3YWlAc3VzZS5kZT4KLS0tCiBz b3VuZC9wY2kvZW5zMTM3MC5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc291bmQvcGNpL2VuczEzNzAuYyBiL3NvdW5k L3BjaS9lbnMxMzcwLmMKaW5kZXggMGRjNDRlYmIwMDMyLi42MjZjZDIxNjdkMjkgMTAwNjQ0Ci0t LSBhL3NvdW5kL3BjaS9lbnMxMzcwLmMKKysrIGIvc291bmQvcGNpL2VuczEzNzAuYwpAQCAtMTU0 OCw3ICsxNTQ4LDcgQEAgc3RhdGljIGludCBzbmRfZXMxMzczX2xpbmVfZ2V0KHN0cnVjdCBzbmRf a2NvbnRyb2wgKmtjb250cm9sLAogCWludCB2YWwgPSAwOwogCQogCXNwaW5fbG9ja19pcnEoJmVu c29uaXEtPnJlZ19sb2NrKTsKLQlpZiAoKGVuc29uaXEtPmN0cmwgJiBFU18xMzcxX0dQSU9fT1VU TSkgPj0gNCkKKwlpZiAoZW5zb25pcS0+Y3RybCAmIEVTXzEzNzFfR1BJT19PVVQoNCkpCiAJICAg IAl2YWwgPSAxOwogCXVjb250cm9sLT52YWx1ZS5pbnRlZ2VyLnZhbHVlWzBdID0gdmFsOwogCXNw aW5fdW5sb2NrX2lycSgmZW5zb25pcS0+cmVnX2xvY2spOwotLSAKMi44LjEKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBs aXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNhLXByb2pl Y3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932181AbcDSNcF (ORCPT ); Tue, 19 Apr 2016 09:32:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:55121 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932071AbcDSNcD (ORCPT ); Tue, 19 Apr 2016 09:32:03 -0400 Date: Tue, 19 Apr 2016 15:31:54 +0200 Message-ID: From: Takashi Iwai To: "David Binderman" Cc: "alsa-devel@alsa-project.org" , "perex@perex.cz" , "linux-kernel@vger.kernel.org" Subject: Re: linux-4.6-rc4/sound/pci/ens1370.c:1551: possible bad expression ? In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Apr 2016 18:17:58 +0200, David Binderman wrote: > > Hello there, > > [linux-4.6-rc4/sound/pci/ens1370.c:1551]: (style) Expression '(X & 0xf0000)>= 0x4' is always false. > > Source code is > >     if ((ensoniq->ctrl & ES_1371_GPIO_OUTM)>= 4) >         val = 1; Thanks for the report. It's fixed now by the patch below. Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] ALSA: ens1371: Fix "Line In->Rear Out Switch" control The "Line In->Rear Out Switch" control on ens1371 driver returns a bogus value, always true, as its check is totally broken. Fix it to check the proper GPIO bit mask. Reported-by: David Binderman Signed-off-by: Takashi Iwai --- sound/pci/ens1370.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/ens1370.c b/sound/pci/ens1370.c index 0dc44ebb0032..626cd2167d29 100644 --- a/sound/pci/ens1370.c +++ b/sound/pci/ens1370.c @@ -1548,7 +1548,7 @@ static int snd_es1373_line_get(struct snd_kcontrol *kcontrol, int val = 0; spin_lock_irq(&ensoniq->reg_lock); - if ((ensoniq->ctrl & ES_1371_GPIO_OUTM) >= 4) + if (ensoniq->ctrl & ES_1371_GPIO_OUT(4)) val = 1; ucontrol->value.integer.value[0] = val; spin_unlock_irq(&ensoniq->reg_lock); -- 2.8.1