All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] topology: print error prefix on error message.
Date: Fri, 07 Aug 2015 18:07:37 +0200	[thread overview]
Message-ID: <s5hvbcrf5fa.wl-tiwai@suse.de> (raw)
In-Reply-To: <1438961956-6239-2-git-send-email-liam.r.girdwood@linux.intel.com>

On Fri, 07 Aug 2015 17:39:16 +0200,
Liam Girdwood wrote:
> 
> Let the user know it's an error.
> 
> Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>

Applied, thanks.


Takashi

> ---
>  src/topology/data.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/topology/data.c b/src/topology/data.c
> index c768bc5..0901851 100644
> --- a/src/topology/data.c
> +++ b/src/topology/data.c
> @@ -384,7 +384,7 @@ int tplg_copy_data(struct tplg_elem *elem, struct tplg_elem *ref)
>  		break;
>  
>  	default:
> -		SNDERR("elem '%s': type %d private data not supported \n",
> +		SNDERR("error: elem '%s': type %d private data not supported \n",
>  			elem->id, elem->type);
>  		return -EINVAL;
>  	}
> -- 
> 2.1.4
> 

  reply	other threads:[~2015-08-07 16:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07 15:39 [PATCH] topology: treat all DAPM controls types the same when copying Liam Girdwood
2015-08-07 15:39 ` [PATCH] topology: print error prefix on error message Liam Girdwood
2015-08-07 16:07   ` Takashi Iwai [this message]
2015-08-07 16:07 ` [PATCH] topology: treat all DAPM controls types the same when copying Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hvbcrf5fa.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.