From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v2] ALSA: hda - Fix Skylake codec timeout Date: Mon, 20 Jul 2015 09:34:13 +0200 Message-ID: References: <1437035964-5658-1-git-send-email-david.henningsson@canonical.com> <96A12704CE18D347B625EE2D4A099D19687270@SHSMSX103.ccr.corp.intel.com> <55A7CE55.5010700@canonical.com> <55A7CFC5.8040707@canonical.com> <96A12704CE18D347B625EE2D4A099D1968766C@SHSMSX103.ccr.corp.intel.com> <96A12704CE18D347B625EE2D4A099D19688898@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 784C62604E4 for ; Mon, 20 Jul 2015 09:34:14 +0200 (CEST) In-Reply-To: <96A12704CE18D347B625EE2D4A099D19688898@SHSMSX103.ccr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Yang, Libin" Cc: "hui.wang@canonical.com" , "Lin, Mengdong" , "alsa-devel@alsa-project.org" , David Henningsson , "Lu, Han" List-Id: alsa-devel@alsa-project.org On Mon, 20 Jul 2015 09:14:15 +0200, Yang, Libin wrote: > > Hi Takashi, > > > -----Original Message----- > > From: Takashi Iwai [mailto:tiwai@suse.de] > > Sent: Friday, July 17, 2015 9:02 PM > > To: Yang, Libin > > Cc: David Henningsson; hui.wang@canonical.com; alsa-devel@alsa- > > project.org; Lin, Mengdong; Lu, Han > > Subject: Re: [PATCH v2] ALSA: hda - Fix Skylake codec timeout > > > > On Fri, 17 Jul 2015 04:28:10 +0200, > > Yang, Libin wrote: > > > > > > > > > > -----Original Message----- > > > > From: Takashi Iwai [mailto:tiwai@suse.de] > > > > Sent: Thursday, July 16, 2015 11:54 PM > > > > To: David Henningsson > > > > Cc: Yang, Libin; hui.wang@canonical.com; alsa-devel@alsa- > > project.org; > > > > Lin, Mengdong; Lu, Han > > > > Subject: Re: [PATCH v2] ALSA: hda - Fix Skylake codec timeout > > > > > > > > On Thu, 16 Jul 2015 17:37:41 +0200, > > > > David Henningsson wrote: > > > > > > > > > > > > > > > > > > > > On 2015-07-16 17:34, Takashi Iwai wrote: > > > > > > On Thu, 16 Jul 2015 17:31:33 +0200, > > > > > > David Henningsson wrote: > > > > > >> > > > > > >> > > > > > >> > > > > > >> On 2015-07-16 17:14, Yang, Libin wrote: > > > > > >>>> -----Original Message----- > > > > > >>>> From: David Henningsson > > > > [mailto:david.henningsson@canonical.com] > > > > > >>>> Sent: Thursday, July 16, 2015 4:39 PM > > > > > >>>> To: tiwai@suse.de; hui.wang@canonical.com; alsa- > > devel@alsa- > > > > > >>>> project.org; Yang, Libin; Lin, Mengdong > > > > > >>>> Cc: David Henningsson > > > > > >>>> Subject: [PATCH v2] ALSA: hda - Fix Skylake codec timeout > > > > > >>>> > > > > > >>>> When the controller is powered up but the HDMI codec is > > > > powered > > > > > >>>> down > > > > > >>>> on Skylake, the power well is turned off. When the codec is > > > > then > > > > > >>>> powered up again, we need to poke the codec a little extra > > to > > > > make > > > > > >>>> sure it wakes up. Otherwise we'll get sad "no response > > from > > > > codec" > > > > > >>>> messages and broken audio. > > > > > >>> > > > > > >>> Thanks for finding this issue. > > > > > >>> > > > > > >>> Could you please give us you test case? We didn't meet such > > > > issue > > > > > >>> before. I would like do a full test on it. > > > > > >> > > > > > >> The test case is: > > > > > >> > > > > > >> - Install Ubuntu 15.04. > > > > > >> - Upgrade to kernel 4.1. > > > > > >> - Boot the new kernel. > > > > > >> > > > > > >> Note: I believe Hui tested with 4.1 and got this error. In my > > case I > > > > > >> have been running a hybrid kernel: Ubuntu 15.04, kernel > > 3.19.0- > > > > 23.24 > > > > > >> (which has a backported i915 driver), and then the alsa-daily > > > > DKMS on > > > > > >> top of that. > > > > > >> > > > > > >> I can email you off-list with details about the machine I tested > > it > > > > on, > > > > > >> if you like. > > > > > > > > > > > > Did you hotplug the device or is it booted while plugged? > > > > > > I had an unstable communication at hotplug / unplug on SKL at > > the > > > > last > > > > > > time, too. But the boot with the DP plugged worked well even > > on > > > > an > > > > > > old SKL box. > > > > > > > > > > For this bug, there was no HDMI monitor connected at all, but I > > > > believe > > > > > it does not matter. On power up, the power well is enabled and > > then > > > > > disabled. When the power well is enabled again without this > > extra > > > > wakeup > > > > > poke (probably due to PulseAudio probing), this error happens. > > > > > > > > Ah, that's interesting. So this happens when no monitor is > > > > connected. I haven't seen this, though; maybe depends on the > > board > > > > or > > > > BIOS. > > > > > > On SKL, each time turning on power well 2, display codec need > > > extra wakeup poke. > > > > > > If there is monitor connected, power well will not be turned > > > off even audio driver asks to. > > > > > > If there is monitor connected, power well will be really > > > turned off. In this case, when hdmi audio is used, we > > > must do the wakeup poke. > > > > So the patch does the right thing? I'm currently waiting for an ack > > from you Intel people as this is highly specific to the chipset > > detail. Please give reviewed-by, acked-by or whatever if the patch is > > OK. > > The patch is right. I have reviewed the patch and Our QA has verified it. OK, I queued the patch now. Thanks. Takashi