From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] regmap: Fix possible sleep-in-atomic in fast io mode Date: Tue, 18 Mar 2014 12:38:42 +0100 Message-ID: References: <1395141600-24558-1-git-send-email-tiwai@suse.de> <20140318112756.GM11706@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20140318112756.GM11706-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Lars-Peter Clausen , Dylan Reid , abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org List-Id: alsa-devel@alsa-project.org At Tue, 18 Mar 2014 11:27:56 +0000, Mark Brown wrote: > > On Tue, Mar 18, 2014 at 12:20:00PM +0100, Takashi Iwai wrote: > > regmap deploys the spinlock for the protection when set up in fast_io > > mode. But some places are still left with possible sleep in the lock, > > typically allocating memory with GFP_KERNEL. This patch fixes these > > calls by moving the allocations out of the lock. > > You should have split these two unrelated changes into two patches. You're suggesting to split the patch to fix for regmap_bulk_write() and regmap_register_patch()? I don't mind to split, but basically both are the very same bug, and the solution is very same, too. > I already have a fix for the cache sync in my tree locally which I will > test just a soon as I fix whatever broke the -next build for me. I don't know why you're talking about the build fix... Takashi