From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 2/4] ASoC: s3c24xx 8 bit sound fix Date: Wed, 12 Nov 2008 16:16:08 +0100 Message-ID: References: <20081112115507.GA22288@rakim.wolfsonmicro.main> <1226490949-22360-1-git-send-email-broonie@opensource.wolfsonmicro.com> <1226490949-22360-2-git-send-email-broonie@opensource.wolfsonmicro.com> <20081112151036.GE8767@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 249E224487 for ; Wed, 12 Nov 2008 16:16:09 +0100 (CET) In-Reply-To: <20081112151036.GE8767@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Christian Pellegrin , Christian Pellegrin List-Id: alsa-devel@alsa-project.org At Wed, 12 Nov 2008 15:10:38 +0000, Mark Brown wrote: > > On Wed, Nov 12, 2008 at 01:33:34PM +0100, Takashi Iwai wrote: > > > I still feel a bit uncomfortable with this as it changes the global > > variables. Maybe better to assign the corresponding fields in the > > local struct. > > The global variable is used to tell the DMA driver how to set the > hardware up for the port. Since the variable is tied to the underlying > hardware channel it's used for there's no real win from duplicating it > into a variable - the hardware it is used to configure can't be shared. I know it, but it's still uncomfortable that such secret mythes and legends are underlying without explanation. Could you add some more comments around that code to avoid misunderstanding by readers? thanks, Takashi