From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v2 2/2] ASoC: add support for Conexant CX2072X CODEC Date: Tue, 11 Apr 2017 15:31:37 +0200 Message-ID: References: <5b7e78fef2c8e299d39ebaa560d81d66e619e7eb.1491382907.git.simon.ho@conexant.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 6DE812666E1 for ; Tue, 11 Apr 2017 15:31:38 +0200 (CEST) In-Reply-To: <5b7e78fef2c8e299d39ebaa560d81d66e619e7eb.1491382907.git.simon.ho@conexant.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: simon.ho.cnxt@gmail.com Cc: pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, Simon Ho , lgirdwood@gmail.com, broonie@kernel.org List-Id: alsa-devel@alsa-project.org On Wed, 05 Apr 2017 11:07:14 +0200, wrote: > > --- /dev/null > +++ b/sound/soc/codecs/cx2072x.c > +/** > + * cx2072x_enable_detect - Enable CX2072X jack detection > + * @codec : pointer variable to codec having information related to codec > + * > + */ > +int cx2072x_enable_detect(struct snd_soc_codec *codec) > +{ ..... > +} > +EXPORT_SYMBOL_GPL(cx2072x_enable_detect); > + > +/* > + * cx2072x_get_jack_state: Return current jack state. > + * @codec : pointer variable to codec having information related to codec > + * > + */ > +int cx2072x_get_jack_state(struct snd_soc_codec *codec) > +{ .... > +} > +EXPORT_SYMBOL_GPL(cx2072x_get_jack_state); > --- /dev/null > +++ b/sound/soc/codecs/cx2072x.h .... > +enum cx2072x_jack_types { > + CX_JACK_NONE = 0x0000, > + CX_JACK_HEADPHONE = 0x0001, > + CX_JACK_APPLE_HEADSET = 0x0002, > + CX_JACK_NOKIE_HEADSET = 0x0003, > +}; > + > +int cx2072x_hs_jack_report(struct snd_soc_codec *codec); This function is nowhere defined. And the new jack functions cx2072x_enable_detect() and cx2072x_get_jack_state() are not declared here, either. Takashi