From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Vinod Koul <vinod.koul@intel.com>,
liam.r.girdwood@linux.intel.com, alsa-devel@alsa-project.org,
Jeeja KP <jeeja.kp@intel.com>,
patches.audio@intel.com
Subject: Re: [PATCH v2 6/6] ASoC: Intel: Skylake: remove call to pci_dev_put
Date: Wed, 16 Mar 2016 12:35:08 +0100 [thread overview]
Message-ID: <s5hwpp2d5ar.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160316110310.GT2566@sirena.org.uk>
On Wed, 16 Mar 2016 12:03:10 +0100,
Mark Brown wrote:
>
> On Wed, Mar 16, 2016 at 04:22:44PM +0530, Vinod Koul wrote:
> > On Wed, Mar 16, 2016 at 10:08:29AM +0000, Mark Brown wrote:
>
> > > Why is the fix for this not to call pci_dev_get()?
>
> > Why do I need either, I see no reason why driver should be doing this,
> > so removed :)
>
> Well, the PCI documentation says that drivers are expected to record a
> reference to their devices in probe(). This is a bit unusual given that
> normally the driver core takes a reference to the device for us but
> presumably there's some reason for this?
Maybe the document is obsoleted. The PCI core, at least the probe /
remove via the normal PCI bus, takes pci_dev_get() and pci_dev_put()
already there.
Takashi
next prev parent reply other threads:[~2016-03-16 11:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 11:09 [PATCH v2 0/6] ASoC: Intel: Skylake: Fix module removal Vinod Koul
2016-03-15 11:09 ` [PATCH v2 1/6] ALSA: hda: use list macro for parsing on cleanup Vinod Koul
2016-03-15 11:09 ` [PATCH v2 2/6] ASoC: Intel: Skylake: free codec objects on removal Vinod Koul
2016-03-16 10:09 ` Applied "ASoC: Intel: Skylake: free codec objects on removal" to the asoc tree Mark Brown
2016-03-15 11:09 ` [PATCH v2 3/6] ASoC: Intel: Skylake: Freeup properly on skl_dsp_free Vinod Koul
2016-03-15 11:09 ` [PATCH v2 4/6] ASoC: Intel: Skylake: Unmap the address last Vinod Koul
2016-03-15 11:09 ` [PATCH v2 5/6] ASoC: Intel: Skylake: Call i915 exit last Vinod Koul
2016-03-15 11:09 ` [PATCH v2 6/6] ASoC: Intel: Skylake: remove call to pci_dev_put Vinod Koul
2016-03-16 10:08 ` Mark Brown
2016-03-16 10:52 ` Vinod Koul
2016-03-16 11:03 ` Mark Brown
2016-03-16 11:35 ` Takashi Iwai [this message]
2016-03-16 14:44 ` Vinod Koul
2016-03-16 14:57 ` Mark Brown
2016-03-16 15:54 ` Vinod Koul
2016-03-16 16:24 ` Applied "ASoC: Intel: Skylake: remove call to pci_dev_put" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwpp2d5ar.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.