From: Takashi Iwai <tiwai@suse.de>
To: Brian Austin <brian.austin@cirrus.com>
Cc: alsa-devel@alsa-project.org, paul.handrigan@cirrus.com,
charles.keepax@cirrus.com
Subject: Re: [PATCH] ALSA: core: Add 384kHz Support
Date: Wed, 27 Jan 2016 15:36:08 +0100 [thread overview]
Message-ID: <s5hwpqv6qef.wl-tiwai@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.10.1601270809340.3329@heelroid>
On Wed, 27 Jan 2016 15:11:10 +0100,
Brian Austin wrote:
>
> On Wed, 27 Jan 2016, Takashi Iwai wrote:
>
> > On Wed, 27 Jan 2016 14:53:45 +0100,
> > <brian.austin@cirrus.com> wrote:
> > >
> > > From: Brian Austin <brian.austin@cirrus.com>
> > >
> > > Adding support for 384kHz audio sample rates
> >
> > The most important information is missing: why this is needed.
> So I can specify that I want 384kHz.
> >
> > (Note that the support of 384kHz itself can be done without this
> > addition :)
> >
> So we stay at SNDRV_PCM_RATE_192000 always for sample rate defines?
> And everything else is just covered with SNDRV_PCM_RATE_KNOT?
Depends. If a new sample rate is (or will be) demanded by many
drivers, it's worth to add it, of course, as it would simplify the
code.
That's why I mentioned "why" is most important information; you need
to convince others about the necessity of this change, after all.
Then you see that "because I-wanna-it" doesn't sound convincing
enough, right?
Takashi
next prev parent reply other threads:[~2016-01-27 14:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 13:53 [PATCH] ALSA: core: Add 384kHz Support brian.austin
2016-01-27 13:59 ` Clemens Ladisch
2016-01-27 14:01 ` Takashi Iwai
2016-01-27 14:11 ` Brian Austin
2016-01-27 14:16 ` Brian Austin
2016-01-27 14:36 ` Takashi Iwai [this message]
2016-01-27 15:02 ` Brian Austin
2016-01-27 15:51 ` Takashi Iwai
2016-01-27 16:55 ` Lars-Peter Clausen
2016-01-27 17:44 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwpqv6qef.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=charles.keepax@cirrus.com \
--cc=paul.handrigan@cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.