All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Peter Stokes <linux@dadeos.co.uk>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] Bug in aplay/arecord --list-pcms
Date: Mon, 12 Jan 2009 12:32:29 +0100	[thread overview]
Message-ID: <s5hwsd0dak2.wl%tiwai@suse.de> (raw)
In-Reply-To: <200901111505.21730.linux@dadeos.co.uk>

At Sun, 11 Jan 2009 15:05:21 +0000,
Peter Stokes wrote:
> 
> Hi,
> 
> I have just discovered a minor logic inversion bug in aplay/arecord --list-pcms functionality.
> 
> Basically, executing "aplay --list-pcms" lists all devices capable of capture and executing "arecord --list-pcms" 
> lists all devices capable of playback.
> 
> Please find below a patch to resolve this issue.
> 
> Best regards
> 
> Peter Stokes
> 
> -------------------------------------------------------------------------------
> 
> Signed-off-by: Peter Stokes <linux@dadeos.co.uk>

Thanks!  Applied now.


Takashi

> 
> diff --git a/aplay/aplay.c b/aplay/aplay.c
> index 2e14d2a..837e46a 100644
> --- a/aplay/aplay.c
> +++ b/aplay/aplay.c
> @@ -287,7 +287,7 @@ static void pcm_list(void)
>                 name = snd_device_name_get_hint(*n, "NAME");
>                 descr = snd_device_name_get_hint(*n, "DESC");
>                 io = snd_device_name_get_hint(*n, "IOID");
> -               if (io != NULL && strcmp(io, filter) == 0)
> +               if (io != NULL && strcmp(io, filter) != 0)
>                         goto __end;
>                 printf("%s\n", name);
>                 if ((descr1 = descr) != NULL) {
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

      reply	other threads:[~2009-01-12 11:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-11 15:05 [PATCH] Bug in aplay/arecord --list-pcms Peter Stokes
2009-01-12 11:32 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hwsd0dak2.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux@dadeos.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.