Re: [PATCH] Add framework for better audigy sound card capabilities selection.

[Takashi Iwai <tiwai@suse.de>]

At Mon, 21 Mar 2005 21:22:54 +0000,
James Courtier-Dutton wrote:
> 
> [1  <text/plain; ISO-8859-1 (7bit)>]
> Takashi Iwai wrote:
> > Hi,
> > 
> > the idea looks nice, but...
> > 
> 
> Is this better?

Thanks!  One more correction below:

> --- alsa-driver/alsa-kernel/pci/emu10k1/emu10k1_main.c	17 Mar 2005 15:55:16 -0000	1.45
> +++ alsa-driver/alsa-kernel/pci/emu10k1/emu10k1_main.c	21 Mar 2005 21:18:50 -0000
> @@ -612,6 +612,144 @@
>  	return snd_emu10k1_free(emu);
>  }
>  
> +/* vendor, device, subsystem, emu10k1_chip, emu10k2_chip, ca0102_chip, ca0108_chip, ca0151_chip, spk71, spdif_bug, ac97_chip, ecard, driver, name */
> +
> +static emu_chip_details_t emu_chip_details[] = {
> +	/* Audigy 2 Value AC3 out does not work yet. Need to find out how to turn off interpolators.*/
> +	{.vendor = 0x1102, .device = 0x0008, .subsystem = 0x10011102,
> +	 .emu10k1_chip = 0,

You don't need to initialize fields with zero.
That's another advantage of this initialization style.


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click