From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: Bug in acore/memalloc.patch in alsa-driver-1.0.7?
Date: Fri, 19 Nov 2004 18:50:44 +0100
Message-ID: <s5hwtwhaft7.wl@alsa2.suse.de>
References: <DBFABB80F7FD3143A911F9E6CFD477B002A7F816@hqemmail02.nvidia.com>
Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
Return-path: <alsa-devel-admin@lists.sourceforge.net>
In-Reply-To: <DBFABB80F7FD3143A911F9E6CFD477B002A7F816@hqemmail02.nvidia.com>
Sender: alsa-devel-admin@lists.sourceforge.net
Errors-To: alsa-devel-admin@lists.sourceforge.net
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Post: <mailto:alsa-devel@lists.sourceforge.net>
List-Help: <mailto:alsa-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=subscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=alsa-devel>
To: Stephen Warren <SWarren@nvidia.com>
Cc: alsa-devel@lists.sourceforge.net
List-Id: alsa-devel@alsa-project.org

At Fri, 19 Nov 2004 09:05:43 -0800,
Stephen Warren wrote:
> 
> This changes the code from
> 
> -       if (dev == NULL || !dev->dma_mask)
> 
> to:
> 
> -       if (dev == NULL || (dev)->dma_mask)
> 
> Once the macro is expanded for kernels 2.6.0 or later.
> 
> This seems to be a bug, since the test is inverted.

Yep, you're ring.  Now fixed on cvs.
Thanks.


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8