From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Click after draining Date: Mon, 18 Oct 2004 17:10:48 +0200 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Giuliano Pochini Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Mon, 18 Oct 2004 16:56:11 +0200 (CEST), Giuliano Pochini wrote: > > >> Anyway, calling _fill_silence() with length=runtime->period_size - delta is > >> wrong IMHO because not all periods have have the same size. The last one can > >> be smaller and in that case it will overflow. > > > > The period size is always same even for the last period, AFAIK. > > Only if the driver explicitly asks for it by calling > snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS). No, this means that buffer_size = N * period_size, where N is integer. Without this constraint, N doesn't have to be an integer. Takashi ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl