From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] usbaudio fixes Date: Mon, 24 Nov 2003 12:27:24 +0100 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: Errors-To: alsa-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: Clemens Ladisch Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Mon, 24 Nov 2003 08:46:08 +0100 (MET), Clemens Ladisch wrote: > > > - don't clear active_mask bits until it's clear that the URB is _not_ > resubmitted, to prevent a race with unlinking > - initialize active_mask and unlink_mask each time before URBs are > started we still need to check here whether the urbs are really free, since a path like trigger stop -> prepare -> trigger_start is possible. in this case, the operation can be done quickly enough before urbs are really unlinked. the question is then where we can do a long wait. perpare would be a better place than trigger, but unfortunately, prepare callback is also regarded as atomic because of linked streams. the patch looks nice, btw. i already have a similar version on my tree for testing, but wasn't applied because of the reason above. i'll apply your patch now to cvs, and let's solve the prepare problem later. Takashi ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/