From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: trident problem Date: Thu, 16 Jan 2003 19:19:21 +0100 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: <873cnu2kml.fsf@adonis.lbl.gov> <87lm1lt1ex.fsf@sycorax.lbl.gov> Mime-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi") Content-Type: multipart/mixed; boundary="Multipart_Thu_Jan_16_19:19:21_2003-1" Return-path: In-Reply-To: <87lm1lt1ex.fsf@sycorax.lbl.gov> Errors-To: alsa-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: Alex Romosan Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org --Multipart_Thu_Jan_16_19:19:21_2003-1 Content-Type: text/plain; charset=US-ASCII At Thu, 16 Jan 2003 10:06:14 -0800, Alex Romosan wrote: > > Takashi Iwai writes: > > > At 15 Jan 2003 13:01:06 -0800, > > Alex Romosan wrote: > >> > >> the latest cvs update (from a few days ago, since sourceforge seems to > >> have problems with anonymous cvs) broke the trident driver. when i try > >> to play a sound file i get the following: > >> > >> kernel: ALSA ../../alsa-kernel/pci/trident/trident_memory.c:192: bad MAGIC (0xa55a5a5a) > >> > >> any ideas? > > > > this must have been already fixed on the latest cvs... > > i downloaded the latest cvs snapshot (2003-01-14) but the problem is > still there. i got it. sorry, my typos. the patch attached. Takashi --Multipart_Thu_Jan_16_19:19:21_2003-1 Content-Type: application/octet-stream Content-Disposition: attachment; filename="trident-fix2.dif" Content-Transfer-Encoding: 7bit Index: alsa-kernel/pci/trident/trident_main.c =================================================================== RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/trident/trident_main.c,v retrieving revision 1.21 diff -u -r1.21 trident_main.c --- alsa-kernel/pci/trident/trident_main.c 13 Jan 2003 09:07:53 -0000 1.21 +++ alsa-kernel/pci/trident/trident_main.c 16 Jan 2003 18:17:49 -0000 @@ -2173,7 +2173,7 @@ strcpy(pcm->name, "Trident 4DWave"); trident->pcm = pcm; - if (! trident->tlb.entries) + if (trident->tlb.entries) snd_pcm_lib_preallocate_sg_pages_for_all(trident->pci, pcm); else snd_pcm_lib_preallocate_pci_pages_for_all(trident->pci, pcm, 64*1024, 128*1024); @@ -2228,7 +2228,7 @@ } trident->foldback = foldback; - if (! trident->tlb.entries) + if (trident->tlb.entries) snd_pcm_lib_preallocate_sg_pages_for_all(trident->pci, foldback); else snd_pcm_lib_preallocate_pci_pages_for_all(trident->pci, foldback, 64*1024, 128*1024); @@ -2272,7 +2272,7 @@ strcpy(spdif->name, "Trident 4DWave IEC958"); trident->spdif = spdif; - if (! trident->tlb.entries) + if (trident->tlb.entries) snd_pcm_lib_preallocate_sg_pages_for_all(trident->pci, spdif); else snd_pcm_lib_preallocate_pci_pages_for_all(trident->pci, spdif, 64*1024, 128*1024); --Multipart_Thu_Jan_16_19:19:21_2003-1-- ------------------------------------------------------- This SF.NET email is sponsored by: Thawte.com Understand how to protect your customers personal information by implementing SSL on your Apache Web Server. Click here to get our FREE Thawte Apache Guide: http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0029en