From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Patch: YMF753 AC '97 Date: Tue, 24 Sep 2002 12:41:54 +0200 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: <200209240428.g8O4S9321071@mail12.bigmailbox.com> Mime-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <200209240428.g8O4S9321071@mail12.bigmailbox.com> Errors-To: alsa-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: David Shust Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Mon, 23 Sep 2002 21:28:09 -0700, David Shust wrote: > > I've written a patches for the 0.9.0rc2 and 0.9.0rc3 ac97-codec > driver in order to support the Yamaha YMF753. This chip is used in > the Toshiba Satellite 5000. Support is provided for S/PDIF output, > enhanced (wide) stereo, and the non-standard tone controls. All > features appear to work. > > Grab it here: www.shustring.net thanks for your patch. the patch looks good except for the module options for spdif. since ac97_codec is a generic module, it's better to avoid such device specific options. isn't it detectable? > I would be delighted to have this merged with the ALSA driver, > provided that my copyright notice is left intact. It is only written > to the console if and when the YMF753 is actually detected: ALSA > AC'97 patch for Yamaha YMF753 (c) David Shust > > Is this an unreasonable request? we can keep it if you want, but please note that we don't print any messages generally from the ALSA driver. ciao, Takashi ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf