From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: More CS4630, secondary CODEC output. Date: Thu, 01 Aug 2002 12:57:23 +0200 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: <3D41D4DC.60004@cucumelo.org> <3D4901D9.7040409@cucumelo.org> Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from Cantor.suse.de (ns.suse.de [213.95.15.193]) by alsa.alsa-project.org (8.9.3/8.9.3/SuSE Linux 8.9.3-0.1) with ESMTP id MAA04545 for ; Thu, 1 Aug 2002 12:57:25 +0200 In-Reply-To: <3D4901D9.7040409@cucumelo.org> Errors-To: alsa-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: Benny Sjostrand Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Thu, 01 Aug 2002 11:39:37 +0200, Benny Sjostrand wrote: > > > > > > > > >I merged your codes into the cvs. > >The codes are almost identical except for small bugfixes, > >re-indentation, and replacement of debug printing. > > > -:) > > > > >To be sure, the old dsp image is still chosen unless > >CONFIG_SND_CS46XX_NEW_DSP is set to yes. > >For compiling the new dsp image, please remove the comments in > >alsa-driver/pci/cs46xx/Makefile. > > > With the new PCM multi channel support, I believe there no way > to have the support for the old image, to many changes in cs46xx_lib.c now > hardly depends on the new stuff. yep, looks so... > So if we want to still support the old code i think the only way is to > create > a new directory alsa-driver/pci/cs46xx_old/_new, having to independent > cs46xx drivers. i'm now merging the new stuff. let's see what happens. > But I hope that in some near future we can discard the old cs46xx. > Of course that we must be sure it work at least so good as before with all > known CS46xx soundcards before discarding anything. yes. if the new driver is confirmed to work on most of machines (cs46xx is used on many notebooks), then we can obsolete it. > > >Please send patches againt cvs if you modify the driver more, so that > >I can commit it soon. > > > Well, i got some more work to do. I will try fixup my new code changes > so it follows > the coding-style used by ALSA, and then become mergable with current CVS. > (and you dont have to do all thoose indentation fixes again) the coding-style of ALSA is not particular except for its naming rule. we followed the standard kernel coding style. as said, i'm now managing to merge the 0731 stuff. just a moment... ciao, Takashi ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf