From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58AB5C433F5 for ; Thu, 18 Nov 2021 13:34:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1566E617E5 for ; Thu, 18 Nov 2021 13:34:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1566E617E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 26DD5181F; Thu, 18 Nov 2021 14:34:06 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 26DD5181F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1637242496; bh=Vk7B+SbTFVrp90gT6ZEYsUS/9d+P/IDQgl5CAcKG4qA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oMouG3UvNUod/Xw+sXQtK+Cq84Vi1o24x/feIB15mlZMwKP/22QrqTPK9AzX1YwW7 zyGKYCb9zUZwaQW0V3wMX5mz38YYs1lQVcn5p+006aPo3noz+13WyrRQVOGRlcUGuF WD62deGQCYhBdu6IDH8QFV2mZYjsODQLfHDGtpLY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B1A52F8026D; Thu, 18 Nov 2021 14:34:05 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E770DF80272; Thu, 18 Nov 2021 14:34:03 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7EEB3F800FA for ; Thu, 18 Nov 2021 14:33:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7EEB3F800FA Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Z4vR9Aaf"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zj1mC8yk" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id DC15221891; Thu, 18 Nov 2021 13:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1637242430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o/2YbNV6NVTFla3wlTg4xaDtv/fczGAO/Q0JkY4Ef/A=; b=Z4vR9AafeEX8duGJjLirPBTKPhsQ5Iu1cbF+EpmARtTsGcpzcsNiNeKgwcRuDGp7O3X1Ai LblfBCjeDzIa2THj4pkbzCqZiN/7sNBpzzIikSKPUb7PxxJTFoLZfwT9NSyFlbXP3X6Ov4 V/VTMBSsUnTRCL1MPsA/DdEzCuPKpNw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1637242430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o/2YbNV6NVTFla3wlTg4xaDtv/fczGAO/Q0JkY4Ef/A=; b=zj1mC8ykvi7FIl78G73BAOmCVmYUZEtc8q84F/RNtcx4BrcdFcwMnQVok7PmWIf7FU8tmH eEuwUCDIvGeb84CQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id CFC44A3B81; Thu, 18 Nov 2021 13:33:50 +0000 (UTC) Date: Thu, 18 Nov 2021 14:33:50 +0100 Message-ID: From: Takashi Iwai To: Sameer Pujar Subject: Re: [PATCH v3 00/16] Kcontrol get/put cleanup in Tegra drivers In-Reply-To: <1637219231-406-1-git-send-email-spujar@nvidia.com> References: <1637219231-406-1-git-send-email-spujar@nvidia.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, tiwai@suse.com, jonathanh@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 18 Nov 2021 08:06:55 +0100, Sameer Pujar wrote: > > There are two cleanups in the series: > 1. Use correct value type for enum controls. This is suggested by > Takashi during review of v2. > > 2. This series fixes kcontrol put callback in some of the Tegra drivers > which are used on platforms based on Tegra210 and later. The callback > is expected to return 1 whenever the HW update is done. > > This idea is suggested by Jaroslav. Similar suggestion came from > Mark during review of series [0] and drivers under this were updated > to return 1, but missed to take care of duplicate updates. This series > updates all concerned drivers to return proper values and duplicate > updates are filtered out. > > I have added 'Suggested-by" tags accordingly. > > [0] https://lore.kernel.org/linux-arm-kernel/20210913142307.GF4283@sirena.org.uk/ > > Changelog > ========= > v2->v3: > ------- > * Add fixes related to wrong value type as suggested by Takashi. > Relevant drivers are updated as part of it. > > * Use separate get/put callbacks for each mixer control. The common > part is pushed to separate function wherever applicable, thus > removing usage of strstr() calls. The return values are fixed > as suggested. > > > v1->v2: > ------- > * ADMAIF, I2S, DMIC and DSPK drivers updated to take care of > duplicate updates. > * Similarly new patches are added for AHUB, MVC, SFC, AMX, ADX > and Mixer drivers. > > Sameer Pujar (16): > ASoC: tegra: Fix wrong value type in ADMAIF > ASoC: tegra: Fix wrong value type in I2S > ASoC: tegra: Fix wrong value type in DMIC > ASoC: tegra: Fix wrong value type in DSPK > ASoC: tegra: Fix wrong value type in SFC > ASoC: tegra: Fix wrong value type in MVC > ASoC: tegra: Fix kcontrol put callback in ADMAIF > ASoC: tegra: Fix kcontrol put callback in I2S > ASoC: tegra: Fix kcontrol put callback in DMIC > ASoC: tegra: Fix kcontrol put callback in DSPK > ASoC: tegra: Fix kcontrol put callback in AHUB > ASoC: tegra: Fix kcontrol put callback in MVC > ASoC: tegra: Fix kcontrol put callback in SFC > ASoC: tegra: Fix kcontrol put callback in AMX > ASoC: tegra: Fix kcontrol put callback in ADX > ASoC: tegra: Fix kcontrol put callback in Mixer Through a quick glance, the series looks good to me. One place could be more optimized with a regmap helper, but it's a minor issue and can be updated later, too. Reviewed-by: Takashi Iwai thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5DFAC433F5 for ; Thu, 18 Nov 2021 13:33:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA3296152B for ; Thu, 18 Nov 2021 13:33:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231392AbhKRNgw (ORCPT ); Thu, 18 Nov 2021 08:36:52 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:39628 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229914AbhKRNgv (ORCPT ); Thu, 18 Nov 2021 08:36:51 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id DC15221891; Thu, 18 Nov 2021 13:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1637242430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o/2YbNV6NVTFla3wlTg4xaDtv/fczGAO/Q0JkY4Ef/A=; b=Z4vR9AafeEX8duGJjLirPBTKPhsQ5Iu1cbF+EpmARtTsGcpzcsNiNeKgwcRuDGp7O3X1Ai LblfBCjeDzIa2THj4pkbzCqZiN/7sNBpzzIikSKPUb7PxxJTFoLZfwT9NSyFlbXP3X6Ov4 V/VTMBSsUnTRCL1MPsA/DdEzCuPKpNw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1637242430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o/2YbNV6NVTFla3wlTg4xaDtv/fczGAO/Q0JkY4Ef/A=; b=zj1mC8ykvi7FIl78G73BAOmCVmYUZEtc8q84F/RNtcx4BrcdFcwMnQVok7PmWIf7FU8tmH eEuwUCDIvGeb84CQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id CFC44A3B81; Thu, 18 Nov 2021 13:33:50 +0000 (UTC) Date: Thu, 18 Nov 2021 14:33:50 +0100 Message-ID: From: Takashi Iwai To: Sameer Pujar Cc: , , , , , , , , Subject: Re: [PATCH v3 00/16] Kcontrol get/put cleanup in Tegra drivers In-Reply-To: <1637219231-406-1-git-send-email-spujar@nvidia.com> References: <1637219231-406-1-git-send-email-spujar@nvidia.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Thu, 18 Nov 2021 08:06:55 +0100, Sameer Pujar wrote: > > There are two cleanups in the series: > 1. Use correct value type for enum controls. This is suggested by > Takashi during review of v2. > > 2. This series fixes kcontrol put callback in some of the Tegra drivers > which are used on platforms based on Tegra210 and later. The callback > is expected to return 1 whenever the HW update is done. > > This idea is suggested by Jaroslav. Similar suggestion came from > Mark during review of series [0] and drivers under this were updated > to return 1, but missed to take care of duplicate updates. This series > updates all concerned drivers to return proper values and duplicate > updates are filtered out. > > I have added 'Suggested-by" tags accordingly. > > [0] https://lore.kernel.org/linux-arm-kernel/20210913142307.GF4283@sirena.org.uk/ > > Changelog > ========= > v2->v3: > ------- > * Add fixes related to wrong value type as suggested by Takashi. > Relevant drivers are updated as part of it. > > * Use separate get/put callbacks for each mixer control. The common > part is pushed to separate function wherever applicable, thus > removing usage of strstr() calls. The return values are fixed > as suggested. > > > v1->v2: > ------- > * ADMAIF, I2S, DMIC and DSPK drivers updated to take care of > duplicate updates. > * Similarly new patches are added for AHUB, MVC, SFC, AMX, ADX > and Mixer drivers. > > Sameer Pujar (16): > ASoC: tegra: Fix wrong value type in ADMAIF > ASoC: tegra: Fix wrong value type in I2S > ASoC: tegra: Fix wrong value type in DMIC > ASoC: tegra: Fix wrong value type in DSPK > ASoC: tegra: Fix wrong value type in SFC > ASoC: tegra: Fix wrong value type in MVC > ASoC: tegra: Fix kcontrol put callback in ADMAIF > ASoC: tegra: Fix kcontrol put callback in I2S > ASoC: tegra: Fix kcontrol put callback in DMIC > ASoC: tegra: Fix kcontrol put callback in DSPK > ASoC: tegra: Fix kcontrol put callback in AHUB > ASoC: tegra: Fix kcontrol put callback in MVC > ASoC: tegra: Fix kcontrol put callback in SFC > ASoC: tegra: Fix kcontrol put callback in AMX > ASoC: tegra: Fix kcontrol put callback in ADX > ASoC: tegra: Fix kcontrol put callback in Mixer Through a quick glance, the series looks good to me. One place could be more optimized with a regmap helper, but it's a minor issue and can be updated later, too. Reviewed-by: Takashi Iwai thanks, Takashi