From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: Re: [PATCH] Add mixer controls to intel8x0m
Date: Wed, 23 Feb 2005 11:20:21 +0100
Message-ID: <s5hy8dfshlm.wl@alsa2.suse.de>
References: <977226cd05022215084074718@mail.gmail.com>
	<977226cd05022215142133ecc4@mail.gmail.com>
Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
In-Reply-To: <977226cd05022215142133ecc4@mail.gmail.com>
Sender: alsa-devel-admin@lists.sourceforge.net
Errors-To: alsa-devel-admin@lists.sourceforge.net
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Post: <mailto:alsa-devel@lists.sourceforge.net>
List-Help: <mailto:alsa-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=subscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=alsa-devel>
To: Jaime Lopez <jsollano@gmail.com>
Cc: alsa-devel@lists.sourceforge.net
List-Id: alsa-devel@alsa-project.org

At Tue, 22 Feb 2005 17:14:01 -0600,
Jaime Lopez wrote:
> 
> oops. forgot to include the diff:

Please create a unified style patch with diff -u.
Also, don't forget to provide "Signed-off-by" line, too, such as

	Signed-off-by: Foo Bar <foo@bar.com>

to add your credit to changelog.


The patch looks almost OK to me (if it works :)

Some points I noticed, though:

- The callback function names can be other ones that match better to
  the control itself
- Remove spin_lock_irq() around snd_ac97_*() calls
- Clean up the comments


thanks,

Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click